From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00D2CE732C8 for ; Thu, 28 Sep 2023 13:08:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232666AbjI1NIZ (ORCPT ); Thu, 28 Sep 2023 09:08:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232590AbjI1NIV (ORCPT ); Thu, 28 Sep 2023 09:08:21 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE4A819C; Thu, 28 Sep 2023 06:08:16 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 582FDC433C8; Thu, 28 Sep 2023 13:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695906496; bh=FgvrFkLj5yALBmEOjNK1KfhRZZ+9X76BFIOyFCpvUuI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Izb656/IaNyoP69KH2Jadd3UbLfQ6FgPWbsbXin0u85ElT4sCrhpAguqFkYo7ICcY eKcKjc3AORwEnGZf+kyhQfyh4pICyZ0yb+QJhpqRz0yRXR+hou8eojCnqWqNTr68KG E8c6+NL5lN89WUQLCfvqpK8ZK+2Dhmobfq03r9Wk= Date: Thu, 28 Sep 2023 15:08:12 +0200 From: Greg KH To: Ekansh Gupta Cc: srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, ekangupt@qti.qualcomm.com, linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com Subject: Re: [PATCH v1] misc: fastrpc: Reset metadata buffer to avoid incorrect free Message-ID: <2023092840-balmy-proved-e337@gregkh> References: <1693463723-16937-1-git-send-email-quic_ekangupt@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1693463723-16937-1-git-send-email-quic_ekangupt@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 31, 2023 at 12:05:23PM +0530, Ekansh Gupta wrote: > Metadata buffer is allocated during get_args for any remote call. > This buffer carries buffers, fdlists and other payload information > for the call. If the buffer is not reset, put_args might find some > garbage FDs in the fdlist which might have an existing mapping in > the list. This could result in improper freeing of FD map when DSP > might still be using the buffer. Added change to reset the metadata > buffer after allocation. > > Signed-off-by: Ekansh Gupta What commit id does this fix? And you sent 3 patches, but not in a list, what order are they to be applied in? thanks, greg k-h