From: Kees Cook <keescook@chromium.org>
To: Brian Geffon <bgeffon@google.com>
Cc: Christian Brauner <brauner@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pid: Allow frozen userspace to reboot from non-init pid ns
Date: Fri, 29 Sep 2023 13:09:52 -0700 [thread overview]
Message-ID: <202309291304.9AC4F5CFB@keescook> (raw)
In-Reply-To: <20230929174442.1635558-1-bgeffon@google.com>
On Fri, Sep 29, 2023 at 01:44:42PM -0400, Brian Geffon wrote:
> When the system has a frozen userspace, for example, during hibernation
> the child reaper task will also be frozen. Attmepting to deliver a
> signal to it to handle the reboot(2) will ultimately lead to the system
> hanging unless userspace is thawed.
>
> This change checks if the current task is the suspending task and if so
> it will allow it to proceed with a reboot from the non-init pid ns.
I don't know the code flow too well here, but shouldn't init_pid_ns
always be doing the reboot regardless of anything else?
Also how is this syscall running if current is frozen? This feels weird
to me... shouldn't the frozen test be against pid_ns->child_reaper
instead of current?
-Kees
--
Kees Cook
next prev parent reply other threads:[~2023-09-29 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 17:44 [PATCH] pid: Allow frozen userspace to reboot from non-init pid ns Brian Geffon
2023-09-29 20:09 ` Kees Cook [this message]
2023-09-30 0:25 ` Brian Geffon
2023-10-09 20:05 ` Kees Cook
2023-10-12 3:53 ` Eric W. Biederman
2023-10-12 9:48 ` Rafael J. Wysocki
2023-10-17 19:00 ` Brian Geffon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309291304.9AC4F5CFB@keescook \
--to=keescook@chromium.org \
--cc=bgeffon@google.com \
--cc=brauner@kernel.org \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mka@chromium.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox