From: kernel test robot <lkp@intel.com>
To: Earl Chew <earl.chew@yahoo.ca>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org
Cc: oe-kbuild-all@lists.linux.dev, peter@hurleysoftware.com,
earl.chew@yahoo.ca, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 2/3] tty: Serialise racing tiocspgrp() callers
Date: Fri, 29 Sep 2023 14:07:43 +0800 [thread overview]
Message-ID: <202309291311.hbeO1nmm-lkp@intel.com> (raw)
In-Reply-To: <20230928130658.4045344-3-earl.chew@yahoo.ca>
Hi Earl,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on tty/tty-next tty/tty-linus linus/master v6.6-rc3 next-20230928]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Earl-Chew/tty-Fix-__tty_check_change-and-tiocspgrp-race/20230929-010931
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20230928130658.4045344-3-earl.chew%40yahoo.ca
patch subject: [PATCH v2 2/3] tty: Serialise racing tiocspgrp() callers
config: i386-randconfig-062-20230929 (https://download.01.org/0day-ci/archive/20230929/202309291311.hbeO1nmm-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230929/202309291311.hbeO1nmm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309291311.hbeO1nmm-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/tty/tty_jobctrl.c:83:52: sparse: sparse: Using plain integer as NULL pointer
drivers/tty/tty_jobctrl.c:88:45: sparse: sparse: Using plain integer as NULL pointer
drivers/tty/tty_jobctrl.c:97:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:97:9: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:97:9: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:100:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:100:34: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:100:34: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:141:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:141:31: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:141:31: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:143:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:143:33: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:143:33: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:152:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:152:31: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:152:31: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:173:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:173:33: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:173:33: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:182:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:182:9: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:182:9: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:184:40: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:184:40: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:184:40: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:222:41: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:222:41: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:222:41: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:232:51: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:232:51: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:232:51: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:244:43: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:244:43: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:244:43: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:308:39: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:308:39: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:308:39: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:311:41: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:311:41: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:311:41: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:340:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:340:31: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:340:31: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:343:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
drivers/tty/tty_jobctrl.c:343:33: sparse: expected struct spinlock [usertype] *lock
drivers/tty/tty_jobctrl.c:343:33: sparse: got struct spinlock [noderef] __rcu *
drivers/tty/tty_jobctrl.c:19:41: sparse: sparse: dereference of noderef expression
drivers/tty/tty_jobctrl.c: note: in included file (through include/linux/rculist.h, include/linux/sched/signal.h):
include/linux/rcupdate.h:778:9: sparse: sparse: context imbalance in '__tty_check_change_locked' - different lock contexts for basic block
vim +83 drivers/tty/tty_jobctrl.c
80
81 int __tty_check_change(struct tty_struct *tty, int sig)
82 {
> 83 return __tty_check_change_locked(tty, sig, 0);
84 }
85
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-29 6:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230831143645.2298799-1-earl_chew@yahoo.com>
2023-09-01 1:50 ` [PATCH 0/3] tty: Fix tiocspgrp() related races Earl Chew
2023-09-28 13:06 ` [PATCH v2 " Earl Chew
2023-09-28 13:38 ` Greg KH
2023-09-28 13:06 ` [PATCH v2 1/3] tty: Fix __tty_check_change() and tiocspgrp() race Earl Chew
2023-09-28 13:06 ` [PATCH v2 2/3] tty: Serialise racing tiocspgrp() callers Earl Chew
2023-09-29 6:07 ` kernel test robot [this message]
2023-09-28 13:06 ` [PATCH v2 3/3] tty: Move task_pgrp() after tty->ctrl.lock for consistency Earl Chew
2023-09-01 1:50 ` [PATCH 1/3] tty: Fix __tty_check_change() and tiocspgrp() race Earl Chew
2023-09-01 1:50 ` [PATCH 2/3] tty: Serialise racing tiocspgrp() callers Earl Chew
2023-09-01 16:09 ` kernel test robot
2023-09-01 17:14 ` kernel test robot
2023-09-28 21:00 ` kernel test robot
2023-09-01 1:50 ` [PATCH 3/3] tty: Move task_pgrp() after tty->ctrl.lock for consistency Earl Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309291311.hbeO1nmm-lkp@intel.com \
--to=lkp@intel.com \
--cc=earl.chew@yahoo.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox