Re: [PATCH v2] drm: rcar-du: turn rcar_du_group_get() into void and remove its return value check

kernel test robot
2023-09-30T06:55:22Z

Hi Alexandra,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.6-rc3 next-20230929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Alexandra-Diupina/drm-rcar-du-turn-rcar_du_group_get-into-void-and-remove-its-return-value-check/20230927-184651
base: linus/master
patch link: https://lore.kernel.org/r/20230927104438.30628-1-adiupina%40astralinux.ru
patch subject: [PATCH v2] drm: rcar-du: turn rcar_du_group_get() into void and remove its return value check
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20230930/202309301402.uR7IRQVj-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230930/202309301402.uR7IRQVj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309301402.uR7IRQVj-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/renesas/rcar-du/rcar_du_group.c:203:6: error: conflicting types for 'rcar_du_group_get'; have 'void(struct rcar_du_group *)'
203 | void rcar_du_group_get(struct rcar_du_group *rgrp)
| ^~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.h:20,
from drivers/gpu/drm/renesas/rcar-du/rcar_du_group.c:29:
drivers/gpu/drm/renesas/rcar-du/rcar_du_group.h:57:5: note: previous declaration of 'rcar_du_group_get' with type 'int(struct rcar_du_group *)'
57 | int rcar_du_group_get(struct rcar_du_group *rgrp);
| ^~~~~~~~~~~~~~~~~

vim +203 drivers/gpu/drm/renesas/rcar-du/rcar_du_group.c

194
195 /*
196 * rcar_du_group_get - Acquire a reference to the DU channels group
197 *
198 * Acquiring the first reference setups core registers. A reference must be held
199 * before accessing any hardware registers.
200 *
201 * This function must be called with the DRM mode_config lock held.
202 */
> 203 void rcar_du_group_get(struct rcar_du_group *rgrp)
204 {
205 if (rgrp->use_count)
206 goto done;
207
208 rcar_du_group_setup(rgrp);
209
210 done:
211 rgrp->use_count++;
212 }
213

--
0-DAY CI Kernel Test Service