Re: [PATCH v9 05/14] USB: typec: tps6598x: Check for EEPROM present

Heikki Krogerus
2023-10-03T05:34:20Z

On Sun, Oct 01, 2023 at 04:11:25AM -0400, Abdel Alkuor wrote:
> From: Abdel Alkuor <abdelalkuor@geotab.com>
>
> When an EEPROM is present, tps25750 loads the binary configuration from
> EEPROM. Hence, all we need to do is wait for the device to switch to APP
> mode
>
> Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>

I'm not sure I understand why this needs separate patch, but in any
case:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> Changes in v9:
> - No changes
> Changes in v8:
> - No changes
> Changes in v7:
> - Add driver name to commit subject
> Changes in v6:
> - Update eeprom macro to use TPS instead
> Changes in v5:
> - Incorporating tps25750 into tps6598x driver
>
> drivers/usb/typec/tipd/core.c | 13 +++++++++++++
> drivers/usb/typec/tipd/tps6598x.h | 3 +++
> 2 files changed, 16 insertions(+)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 2e7b9eafaf04..21b0ea2c9627 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -37,6 +37,7 @@
> #define TPS_REG_STATUS 0x1a
> #define TPS_REG_SYSTEM_CONF 0x28
> #define TPS_REG_CTRL_CONF 0x29
> +#define TPS_REG_BOOT_STATUS 0x2D
> #define TPS_REG_POWER_STATUS 0x3f
> #define TPS_REG_RX_IDENTITY_SOP 0x48
> #define TPS_REG_DATA_STATUS 0x5f
> @@ -910,6 +911,17 @@ static int tps25750_apply_patch(struct tps6598x *tps)
> {
> int ret;
> unsigned long timeout;
> + u64 status = 0;
> +
> + ret = tps6598x_block_read(tps, TPS_REG_BOOT_STATUS, &status, 5);
> + if (ret)
> + return ret;
> + /*
> + * Nothing to be done if the configuration
> + * is being loaded from EERPOM
> + */
> + if (status & TPS_BOOT_STATUS_I2C_EEPROM_PRESENT)
> + goto wait_for_app;
>
> ret = tps25750_start_patch_burst_mode(tps);
> if (ret) {
> @@ -921,6 +933,7 @@ static int tps25750_apply_patch(struct tps6598x *tps)
> if (ret)
> return ret;
>
> +wait_for_app:
> timeout = jiffies + msecs_to_jiffies(1000);
>
> do {
> diff --git a/drivers/usb/typec/tipd/tps6598x.h b/drivers/usb/typec/tipd/tps6598x.h
> index 527857549d69..a80d0929f3ee 100644
> --- a/drivers/usb/typec/tipd/tps6598x.h
> +++ b/drivers/usb/typec/tipd/tps6598x.h
> @@ -199,4 +199,7 @@
> #define TPS_DATA_STATUS_DP_SPEC_PIN_ASSIGNMENT_A BIT(2)
> #define TPS_DATA_STATUS_DP_SPEC_PIN_ASSIGNMENT_B (BIT(2) | BIT(1))
>
> +/* BOOT STATUS REG*/
> +#define TPS_BOOT_STATUS_I2C_EEPROM_PRESENT BIT(3)
> +
> #endif /* __TPS6598X_H__ */
> --
> 2.34.1

--
heikki