Re: [PATCH v9 03/14] USB: typec: tps6598x: Add patch mode to tps6598x

Heikki Krogerus
2023-10-03T05:28:45Z

On Sun, Oct 01, 2023 at 04:11:23AM -0400, Abdel Alkuor wrote:
> From: Abdel Alkuor <abdelalkuor@geotab.com>
>
> TPS25750 has a patch mode indicating the device requires
> a configuration to get the device into operational mode
>
> Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> Changes in v9:
> - No changes
> Changes in v8:
> - Revert mode check return
> Changes in v7:
> - Add driver name to commit subject
> Changes in v6:
> - Return current mode and check it directly
> Changes in v5:
> - Incorporating tps25750 into tps6598x driver
>
> drivers/usb/typec/tipd/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 32420c61660d..c5bbf03cb74a 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -68,6 +68,7 @@ enum {
> TPS_MODE_BOOT,
> TPS_MODE_BIST,
> TPS_MODE_DISC,
> + TPS_MODE_PTCH,
> };
>
> static const char *const modes[] = {
> @@ -75,6 +76,7 @@ static const char *const modes[] = {
> [TPS_MODE_BOOT] = "BOOT",
> [TPS_MODE_BIST] = "BIST",
> [TPS_MODE_DISC] = "DISC",
> + [TPS_MODE_PTCH] = "PTCH",
> };
>
> /* Unrecognized commands will be replaced with "!CMD" */
> @@ -595,6 +597,7 @@ static int tps6598x_check_mode(struct tps6598x *tps)
>
> switch (match_string(modes, ARRAY_SIZE(modes), mode)) {
> case TPS_MODE_APP:
> + case TPS_MODE_PTCH:
> return 0;
> case TPS_MODE_BOOT:
> dev_warn(tps->dev, "dead-battery condition\n");
> --
> 2.34.1

--
heikki