Re: [PATCH v9 08/14] USB: typec: tps6598x: Add interrupt support for TPS25750

Abdel Alkuor
2023-10-03T11:19:09Z

On Tue, Oct 03, 2023 at 09:39:59AM +0300, Heikki Krogerus wrote:
> On Sun, Oct 01, 2023 at 04:11:28AM -0400, Abdel Alkuor wrote:
> > From: Abdel Alkuor <abdelalkuor@geotab.com>
> >
> > tps25750 event registers structure is different than tps6598x's,
> > tps25750 has 11 bytes of events which are read at once where
> > tps6598x has two event registers of 8 bytes each which are read
> > separately. Likewise MASK event registers. Also, not all events
> > are supported in both devices.
> >
> > - Create a new handler to accommodate tps25750 interrupt
> > - Add device data to of_device_id
> >
> > Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>
>
> I'm sorry, but I just realised that this one also has to be in place
> by the time TPS25750 is enabled in patch 4/14. Otherwise the series is
> not bisectable.
>
> I think you need to refactor the patch order a bit:
>
> First come the patches that prepare everything that needs preparing -
> introduction of struct tipd_data (without anything TPS25750 specific),
> and so on.
>
> Then you have patches for things that are specific to TPS25750 (small
> stuff just merge together) if needed.
>
> In the very last patches you finally enable TPS25750.
>
No worries. I will aggregate all the patches that are related to
tps25750 into one patch that supports tps25750 implementation and enable
it. The remainig patches after enabling tps25750 are to add trace
support.

Thanks,
Abdel