From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1394E748E9 for ; Sun, 1 Oct 2023 12:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234934AbjJAMWS (ORCPT ); Sun, 1 Oct 2023 08:22:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234938AbjJAMWQ (ORCPT ); Sun, 1 Oct 2023 08:22:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0B7BEB; Sun, 1 Oct 2023 05:22:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87D5AC433C8; Sun, 1 Oct 2023 12:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696162934; bh=KEKIGJ8YzKasW9ukSR/+yIY9EqVyIgke9DbyhZEYjFw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H+UW6dFcaRdFOoLZ8eu0qf9uAYLsCIKFXs3SzihQe2dnCxUI83LjD5C+RUco/Za7q 82Du5oMzjqHcCo8qicNOq5egrBuiM3iSpogdRxWffF55x+Ik2oMiVxZDw1Fpapex2m Rrc8VztWiNvU1pu0N79JYsyG2P8/627ZO9ce/CMoGqxfrZzq/WwvWJdAFCQDGE3hgP b9XxdBAdLthYn+xHRAkrl5xFRv8xAsql413u884WMrDUdpnzYFKmNPVAUo9+761Dfk ytTc3/A17/3FPpWoV6Lw6FQ2u0RBW1/c7l9wCs+IXswyrgQRzaWQFUiQ02ZOGKdATf O4nupdDbKHQEQ== Date: Sun, 1 Oct 2023 14:22:09 +0200 From: Simon Horman To: Markus Schneider-Pargmann Cc: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger , Vincent MAILHOL , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Julien Panis , Judith Mendez Subject: Re: [PATCH v6 01/14] can: m_can: Start/Cancel polling timer together with interrupts Message-ID: <20231001122209.GJ92317@kernel.org> References: <20230929141304.3934380-1-msp@baylibre.com> <20230929141304.3934380-2-msp@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929141304.3934380-2-msp@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 29, 2023 at 04:12:51PM +0200, Markus Schneider-Pargmann wrote: > Interrupts are enabled/disabled in more places than just m_can_start() > and m_can_stop(). Couple the polling timer with enabling/disabling of > all interrupts to achieve equivalent behavior. > > Cc: Judith Mendez > Fixes: b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt") > Signed-off-by: Markus Schneider-Pargmann Reviewed-by: Simon Horman