From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Bergh <bergh.jonathan@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drivers: usb: Fix block comments whose trailing */ was not on a separate line
Date: Sun, 1 Oct 2023 08:06:06 +0200 [thread overview]
Message-ID: <2023100133-exclusive-boss-edc4@gregkh> (raw)
In-Reply-To: <20230930203646.61863-1-bergh.jonathan@gmail.com>
On Sat, Sep 30, 2023 at 10:36:46PM +0200, Jonathan Bergh wrote:
> Fixed various instances where block comments trailing */ where not on a
> separate line and should be.
>
> Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
> ---
> drivers/usb/atm/cxacru.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
Your subject line for these patches is not correct, please fix up.
And the patches are not properly threaded, what happened in your email
client?
And finally, why make coding style changes outside of drivers/staging/?
Did you get the maintainer's approval to do so before taking the time?
Usually most maintainers do not want these so always ask before doing
so, or just stick with drivers/staging/ to learn how the process works
first please.
thanks,
greg k-h
prev parent reply other threads:[~2023-10-01 6:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 20:36 [PATCH 1/3] drivers: usb: Fix block comments whose trailing */ was not on a separate line Jonathan Bergh
2023-10-01 6:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100133-exclusive-boss-edc4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bergh.jonathan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox