* [PATCH] usb: fix kernel-doc warning
@ 2023-09-18 19:35 Swarup Laxman Kotiaklapudi
2023-10-02 14:42 ` Greg KH
2023-10-02 17:05 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
0 siblings, 2 replies; 7+ messages in thread
From: Swarup Laxman Kotiaklapudi @ 2023-09-18 19:35 UTC (permalink / raw)
To: Thinh.Nguyen, gregkh, linux-usb, linux-kernel,
linux-kernel-mentees
Cc: Swarup Laxman Kotiaklapudi
Fix kernel-doc warnings discovered in usb driver.
Fixes this warning:
warning: Function parameter or member 'gfladj_refclk_lpm_sel'
not described in 'dwc3'
Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
---
drivers/usb/dwc3/core.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index a69ac67d89fe..078edfe0f88e 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1106,6 +1106,8 @@ struct dwc3_scratchpad_array {
* instances in park mode.
* @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed
* instances in park mode.
+ * @gfladj_refclk_lpm_sel: set if we need to enable reference clock for LPM in
+ * Global Frame Length Adjustment register
* @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk
* @tx_de_emphasis: Tx de-emphasis value
* 0 - -6dB de-emphasis
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] usb: fix kernel-doc warning
2023-09-18 19:35 [PATCH] usb: fix kernel-doc warning Swarup Laxman Kotiaklapudi
@ 2023-10-02 14:42 ` Greg KH
2023-10-02 15:40 ` swarup
2023-10-02 17:05 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
1 sibling, 1 reply; 7+ messages in thread
From: Greg KH @ 2023-10-02 14:42 UTC (permalink / raw)
To: Swarup Laxman Kotiaklapudi
Cc: Thinh.Nguyen, linux-usb, linux-kernel, linux-kernel-mentees
On Tue, Sep 19, 2023 at 01:05:05AM +0530, Swarup Laxman Kotiaklapudi wrote:
> Fix kernel-doc warnings discovered in usb driver.
> Fixes this warning:
> warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> not described in 'dwc3'
>
> Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> ---
> drivers/usb/dwc3/core.h | 2 ++
> 1 file changed, 2 insertions(+)
What commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] usb: fix kernel-doc warning
2023-10-02 14:42 ` Greg KH
@ 2023-10-02 15:40 ` swarup
2023-10-02 15:46 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: swarup @ 2023-10-02 15:40 UTC (permalink / raw)
To: Greg KH; +Cc: Thinh.Nguyen, linux-usb, linux-kernel, linux-kernel-mentees
On Mon, Oct 02, 2023 at 04:42:03PM +0200, Greg KH wrote:
> On Tue, Sep 19, 2023 at 01:05:05AM +0530, Swarup Laxman Kotiaklapudi wrote:
> > Fix kernel-doc warnings discovered in usb driver.
> > Fixes this warning:
> > warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> > not described in 'dwc3'
> >
> > Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> > ---
> > drivers/usb/dwc3/core.h | 2 ++
> > 1 file changed, 2 insertions(+)
>
> What commit id does this fix?
>
> thanks,
>
> greg k-h
Hi Greg,
Please find the commit id as mentioned below,
next time onwards i will mention it:
Fixes: 5cd07f96c0c6 ("usb: fix kernel-doc warning")
Thanks,
Swarup
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] usb: fix kernel-doc warning
2023-10-02 15:40 ` swarup
@ 2023-10-02 15:46 ` Greg KH
2023-10-02 17:40 ` swarup
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2023-10-02 15:46 UTC (permalink / raw)
To: swarup; +Cc: Thinh.Nguyen, linux-usb, linux-kernel, linux-kernel-mentees
On Mon, Oct 02, 2023 at 09:10:30PM +0530, swarup wrote:
> On Mon, Oct 02, 2023 at 04:42:03PM +0200, Greg KH wrote:
> > On Tue, Sep 19, 2023 at 01:05:05AM +0530, Swarup Laxman Kotiaklapudi wrote:
> > > Fix kernel-doc warnings discovered in usb driver.
> > > Fixes this warning:
> > > warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> > > not described in 'dwc3'
> > >
> > > Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> > > ---
> > > drivers/usb/dwc3/core.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > What commit id does this fix?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
> Please find the commit id as mentioned below,
> next time onwards i will mention it:
>
> Fixes: 5cd07f96c0c6 ("usb: fix kernel-doc warning")
That is not a valid commit id in Linus's tree, are you sure it is
correct?
And please resend the patch with that information in it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] usb: fix kernel-doc warning
2023-09-18 19:35 [PATCH] usb: fix kernel-doc warning Swarup Laxman Kotiaklapudi
2023-10-02 14:42 ` Greg KH
@ 2023-10-02 17:05 ` Swarup Laxman Kotiaklapudi
2023-10-02 18:26 ` Thinh Nguyen
1 sibling, 1 reply; 7+ messages in thread
From: Swarup Laxman Kotiaklapudi @ 2023-10-02 17:05 UTC (permalink / raw)
To: Thinh.Nguyen, gregkh, linux-usb, linux-kernel,
linux-kernel-mentees
Cc: swarupkotikalapudi
Fix kernel-doc warnings discovered in usb driver.
Fixes this warning:
warning: Function parameter or member 'gfladj_refclk_lpm_sel'
not described in 'dwc3'
Fixes: cf1202418e0b ("usb: fix kernel-doc warning")
Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
---
drivers/usb/dwc3/core.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index a69ac67d89fe..078edfe0f88e 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1106,6 +1106,8 @@ struct dwc3_scratchpad_array {
* instances in park mode.
* @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed
* instances in park mode.
+ * @gfladj_refclk_lpm_sel: set if we need to enable reference clock for LPM in
+ * Global Frame Length Adjustment register
* @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk
* @tx_de_emphasis: Tx de-emphasis value
* 0 - -6dB de-emphasis
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] usb: fix kernel-doc warning
2023-10-02 15:46 ` Greg KH
@ 2023-10-02 17:40 ` swarup
0 siblings, 0 replies; 7+ messages in thread
From: swarup @ 2023-10-02 17:40 UTC (permalink / raw)
To: Greg KH, q; +Cc: Thinh.Nguyen, linux-usb, linux-kernel, linux-kernel-mentees
esOn Mon, Oct 02, 2023 at 05:46:49PM +0200, Greg KH wrote:
> On Mon, Oct 02, 2023 at 09:10:30PM +0530, swarup wrote:
> > On Mon, Oct 02, 2023 at 04:42:03PM +0200, Greg KH wrote:
> > > On Tue, Sep 19, 2023 at 01:05:05AM +0530, Swarup Laxman Kotiaklapudi wrote:
> > > > Fix kernel-doc warnings discovered in usb driver.
> > > > Fixes this warning:
> > > > warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> > > > not described in 'dwc3'
> > > >
> > > > Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> > > > ---
> > > > drivers/usb/dwc3/core.h | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > >
> > > What commit id does this fix?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Hi Greg,
> > Please find the commit id as mentioned below,
> > next time onwards i will mention it:
> >
> > Fixes: 5cd07f96c0c6 ("usb: fix kernel-doc warning")
>
> That is not a valid commit id in Linus's tree, are you sure it is
> correct?
>
> And please resend the patch with that information in it.
>
> thanks,
>
> greg k-h
Hi Greg,
I send patch V2, with the Fixes tag being mentioned.
Please check the email.
Thanks,
Swarup
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] usb: fix kernel-doc warning
2023-10-02 17:05 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
@ 2023-10-02 18:26 ` Thinh Nguyen
0 siblings, 0 replies; 7+ messages in thread
From: Thinh Nguyen @ 2023-10-02 18:26 UTC (permalink / raw)
To: Swarup Laxman Kotiaklapudi
Cc: Thinh Nguyen, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
On Mon, Oct 02, 2023, Swarup Laxman Kotiaklapudi wrote:
> Fix kernel-doc warnings discovered in usb driver.
>
> Fixes this warning:
> warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> not described in 'dwc3'
>
> Fixes: cf1202418e0b ("usb: fix kernel-doc warning")
This id doesn't match anything in the mainline kernel.
> Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> ---
Please note changes since v1 here.
> drivers/usb/dwc3/core.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index a69ac67d89fe..078edfe0f88e 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -1106,6 +1106,8 @@ struct dwc3_scratchpad_array {
> * instances in park mode.
> * @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed
> * instances in park mode.
> + * @gfladj_refclk_lpm_sel: set if we need to enable reference clock for LPM in
> + * Global Frame Length Adjustment register
> * @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk
> * @tx_de_emphasis: Tx de-emphasis value
> * 0 - -6dB de-emphasis
> --
> 2.34.1
>
Also, please prefix $subject line with "usb: dwc3:"
Thanks,
Thinh
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-10-02 18:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-18 19:35 [PATCH] usb: fix kernel-doc warning Swarup Laxman Kotiaklapudi
2023-10-02 14:42 ` Greg KH
2023-10-02 15:40 ` swarup
2023-10-02 15:46 ` Greg KH
2023-10-02 17:40 ` swarup
2023-10-02 17:05 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
2023-10-02 18:26 ` Thinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox