* [PATCH] net: lan743x: also select PHYLIB
@ 2023-09-27 4:25 Randy Dunlap
2023-10-02 19:26 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-09-27 4:25 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid
a kconfig warning:
WARNING: unmet direct dependencies detected for FIXED_PHY
Depends on [n]: NETDEVICES [=y] && PHYLIB [=n]
Selected by [y]:
- LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y]
Fixes: 73c4d1b307ae ("net: lan743x: select FIXED_PHY")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: lore.kernel.org/r/202309261802.JPbRHwti-lkp@intel.com
M: Bryan Whitehead <bryan.whitehead@microchip.com>
M: UNGLinuxDriver@microchip.com
M: Simon Horman <horms@kernel.org>
L: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
---
drivers/net/ethernet/microchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
--- a/drivers/net/ethernet/microchip/Kconfig
+++ b/drivers/net/ethernet/microchip/Kconfig
@@ -46,6 +46,7 @@ config LAN743X
tristate "LAN743x support"
depends on PCI
depends on PTP_1588_CLOCK_OPTIONAL
+ select PHYLIB
select FIXED_PHY
select CRC16
select CRC32
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net: lan743x: also select PHYLIB
2023-09-27 4:25 [PATCH] net: lan743x: also select PHYLIB Randy Dunlap
@ 2023-10-02 19:26 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2023-10-02 19:26 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, David S. Miller, Eric Dumazet,
Paolo Abeni
On Tue, 26 Sep 2023 21:25:23 -0700 Randy Dunlap wrote:
> Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid
> a kconfig warning:
>
> WARNING: unmet direct dependencies detected for FIXED_PHY
> Depends on [n]: NETDEVICES [=y] && PHYLIB [=n]
> Selected by [y]:
> - LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y]
Hi Randy!
Could you resend CCing netdev@ ?
It's necessary for the patch to get into our patchwork instance.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-02 19:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 4:25 [PATCH] net: lan743x: also select PHYLIB Randy Dunlap
2023-10-02 19:26 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox