Re: [PATCH] dt-bindings: phy: Convert PXA1928 USB/HSIC PHY to DT schema

Rob Herring
2023-10-02T14:36:34Z

On Sun, Oct 01, 2023 at 03:05:43PM +0200, Duje Mihanović wrote:
> Convert the binding for the Marvell PXA1928 USB and HSIC PHYs from TXT
> to DT schema.
>
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> ---
> .../bindings/phy/marvell,pxa1928-hsic-phy.yaml | 37 +++++++++++++++++
> .../bindings/phy/marvell,pxa1928-usb-phy.yaml | 46 ++++++++++++++++++++++
> .../devicetree/bindings/phy/pxa1928-usb-phy.txt | 18 ---------
> 3 files changed, 83 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/marvell,pxa1928-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,pxa1928-hsic-phy.yaml
> new file mode 100644
> index 000000000000..a477afd11329
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/marvell,pxa1928-hsic-phy.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/marvell,pxa1928-hsic-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA1928 HSIC PHY
> +
> +maintainers:
> + - devicetree@vger.kernel.org

No, should be someone with hardware or familar with it. I added this,
but no longer have h/w or documentation. IMO, it should probably be
removed.

The schemas are the same, so they could just be 1 document.

> +
> +properties:
> + $nodename:
> + pattern: '^phy@[a-f0-9]+$'
> +
> + compatible:
> + const: "marvell,pxa1928-hsic-phy"

Don't need quotes.

> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + '#phy-cells':
> + const: 0
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - '#phy-cells'
> +
> +additionalProperties: false
> diff --git a/Documentation/devicetree/bindings/phy/marvell,pxa1928-usb-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,pxa1928-usb-phy.yaml
> new file mode 100644
> index 000000000000..4ae9201767ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/marvell,pxa1928-usb-phy.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/marvell,pxa1928-usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA1928 USB PHY
> +
> +maintainers:
> + - devicetree@vger.kernel.org
> +
> +properties:
> + $nodename:
> + pattern: '^phy@[a-f0-9]+$'
> +
> + compatible:
> + const: "marvell,pxa1928-usb-phy"
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + '#phy-cells':
> + const: 0
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - '#phy-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + phy@7000 {
> + compatible = "marvell,pxa1928-usb-phy";
> + reg = <0x7000 0xe0>;
> + clocks = <&apmu_clocks PXA1928_CLK_USB>;
> + #phy-cells = <0>;
> + };
> diff --git a/Documentation/devicetree/bindings/phy/pxa1928-usb-phy.txt b/Documentation/devicetree/bindings/phy/pxa1928-usb-phy.txt
> deleted file mode 100644
> index da94426aa694..000000000000
> --- a/Documentation/devicetree/bindings/phy/pxa1928-usb-phy.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* Marvell PXA1928 USB and HSIC PHYs
> -
> -Required properties:
> -- compatible: "marvell,pxa1928-usb-phy" or "marvell,pxa1928-hsic-phy"
> -- reg: base address and length of the registers
> -- clocks - A single clock. From common clock binding.
> -- #phys-cells: should be 0. From common phy binding.
> -- resets: reference to the reset controller
> -
> -Example:
> -
> - usbphy: phy@7000 {
> - compatible = "marvell,pxa1928-usb-phy";
> - reg = <0x7000 0xe0>;
> - clocks = <&apmu_clocks PXA1928_CLK_USB>;
> - #phy-cells = <0>;
> - };
> -
>
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20231001-pxa1928-usb-yaml-809564082241
>
> Best regards,
> --
> Duje Mihanović <duje.mihanovic@skole.hr>
>
>