* drivers/clocksource/timer-ti-dm.c:82: warning: Function parameter or member 'val' not described in 'dmtimer_write'
@ 2023-08-17 11:00 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-08-17 11:00 UTC (permalink / raw)
To: Tony Lindgren
Cc: llvm, oe-kbuild-all, linux-kernel, Daniel Lezcano,
Janusz Krzysztofik
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
commit: 49cd16bb573e43dc2ee64d734b9b545475dbb35f clocksource/drivers/timer-ti-dm: Simplify register writes with dmtimer_write()
date: 11 months ago
config: riscv-randconfig-r002-20230817 (https://download.01.org/0day-ci/archive/20230817/202308171822.ZcUAzWPw-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171822.ZcUAzWPw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308171822.ZcUAzWPw-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/clocksource/timer-ti-dm.c:82: warning: Function parameter or member 'val' not described in 'dmtimer_write'
>> drivers/clocksource/timer-ti-dm.c:82: warning: Excess function parameter 'value' description in 'dmtimer_write'
vim +82 drivers/clocksource/timer-ti-dm.c
41e79b1d458477 Tony Lindgren 2022-04-08 70
49cd16bb573e43 Tony Lindgren 2022-08-15 71 /**
49cd16bb573e43 Tony Lindgren 2022-08-15 72 * dmtimer_write - write timer registers in posted and non-posted mode
49cd16bb573e43 Tony Lindgren 2022-08-15 73 * @timer: timer pointer over which write operation is to perform
49cd16bb573e43 Tony Lindgren 2022-08-15 74 * @reg: lowest byte holds the register offset
49cd16bb573e43 Tony Lindgren 2022-08-15 75 * @value: data to write into the register
49cd16bb573e43 Tony Lindgren 2022-08-15 76 *
49cd16bb573e43 Tony Lindgren 2022-08-15 77 * The posted mode bit is encoded in reg. Note that in posted mode, the write
49cd16bb573e43 Tony Lindgren 2022-08-15 78 * pending bit must be checked. Otherwise a write on a register which has a
49cd16bb573e43 Tony Lindgren 2022-08-15 79 * pending write will be lost.
49cd16bb573e43 Tony Lindgren 2022-08-15 80 */
49cd16bb573e43 Tony Lindgren 2022-08-15 81 static inline void dmtimer_write(struct omap_dm_timer *timer, u32 reg, u32 val)
41e79b1d458477 Tony Lindgren 2022-04-08 @82 {
49cd16bb573e43 Tony Lindgren 2022-08-15 83 u16 wp, offset;
49cd16bb573e43 Tony Lindgren 2022-08-15 84
49cd16bb573e43 Tony Lindgren 2022-08-15 85 wp = reg >> WPSHIFT;
49cd16bb573e43 Tony Lindgren 2022-08-15 86 offset = reg & 0xff;
49cd16bb573e43 Tony Lindgren 2022-08-15 87
49cd16bb573e43 Tony Lindgren 2022-08-15 88 /* Wait for a possible write pending bit in posted mode */
49cd16bb573e43 Tony Lindgren 2022-08-15 89 if (wp && timer->posted)
49cd16bb573e43 Tony Lindgren 2022-08-15 90 while (readl_relaxed(timer->pend) & wp)
41e79b1d458477 Tony Lindgren 2022-04-08 91 cpu_relax();
41e79b1d458477 Tony Lindgren 2022-04-08 92
49cd16bb573e43 Tony Lindgren 2022-08-15 93 writel_relaxed(val, timer->func_base + offset);
41e79b1d458477 Tony Lindgren 2022-04-08 94 }
41e79b1d458477 Tony Lindgren 2022-04-08 95
:::::: The code at line 82 was first introduced by commit
:::::: 41e79b1d458477212d0a880c87622bcaa69ab3ea clocksource/drivers/timer-ti-dm: Move inline functions to driver for am6
:::::: TO: Tony Lindgren <tony@atomide.com>
:::::: CC: Daniel Lezcano <daniel.lezcano@linaro.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/clocksource/timer-ti-dm.c:82: warning: Function parameter or member 'val' not described in 'dmtimer_write'
@ 2023-10-02 9:32 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-10-02 9:32 UTC (permalink / raw)
To: Tony Lindgren
Cc: oe-kbuild-all, linux-kernel, Daniel Lezcano, Janusz Krzysztofik
Hi Tony,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa
commit: 49cd16bb573e43dc2ee64d734b9b545475dbb35f clocksource/drivers/timer-ti-dm: Simplify register writes with dmtimer_write()
date: 1 year ago
config: arm-defconfig (https://download.01.org/0day-ci/archive/20231002/202310021747.wKAwfhnx-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231002/202310021747.wKAwfhnx-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310021747.wKAwfhnx-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/clocksource/timer-ti-dm.c:82: warning: Function parameter or member 'val' not described in 'dmtimer_write'
>> drivers/clocksource/timer-ti-dm.c:82: warning: Excess function parameter 'value' description in 'dmtimer_write'
vim +82 drivers/clocksource/timer-ti-dm.c
41e79b1d458477 Tony Lindgren 2022-04-08 70
49cd16bb573e43 Tony Lindgren 2022-08-15 71 /**
49cd16bb573e43 Tony Lindgren 2022-08-15 72 * dmtimer_write - write timer registers in posted and non-posted mode
49cd16bb573e43 Tony Lindgren 2022-08-15 73 * @timer: timer pointer over which write operation is to perform
49cd16bb573e43 Tony Lindgren 2022-08-15 74 * @reg: lowest byte holds the register offset
49cd16bb573e43 Tony Lindgren 2022-08-15 75 * @value: data to write into the register
49cd16bb573e43 Tony Lindgren 2022-08-15 76 *
49cd16bb573e43 Tony Lindgren 2022-08-15 77 * The posted mode bit is encoded in reg. Note that in posted mode, the write
49cd16bb573e43 Tony Lindgren 2022-08-15 78 * pending bit must be checked. Otherwise a write on a register which has a
49cd16bb573e43 Tony Lindgren 2022-08-15 79 * pending write will be lost.
49cd16bb573e43 Tony Lindgren 2022-08-15 80 */
49cd16bb573e43 Tony Lindgren 2022-08-15 81 static inline void dmtimer_write(struct omap_dm_timer *timer, u32 reg, u32 val)
41e79b1d458477 Tony Lindgren 2022-04-08 @82 {
49cd16bb573e43 Tony Lindgren 2022-08-15 83 u16 wp, offset;
49cd16bb573e43 Tony Lindgren 2022-08-15 84
49cd16bb573e43 Tony Lindgren 2022-08-15 85 wp = reg >> WPSHIFT;
49cd16bb573e43 Tony Lindgren 2022-08-15 86 offset = reg & 0xff;
49cd16bb573e43 Tony Lindgren 2022-08-15 87
49cd16bb573e43 Tony Lindgren 2022-08-15 88 /* Wait for a possible write pending bit in posted mode */
49cd16bb573e43 Tony Lindgren 2022-08-15 89 if (wp && timer->posted)
49cd16bb573e43 Tony Lindgren 2022-08-15 90 while (readl_relaxed(timer->pend) & wp)
41e79b1d458477 Tony Lindgren 2022-04-08 91 cpu_relax();
41e79b1d458477 Tony Lindgren 2022-04-08 92
49cd16bb573e43 Tony Lindgren 2022-08-15 93 writel_relaxed(val, timer->func_base + offset);
41e79b1d458477 Tony Lindgren 2022-04-08 94 }
41e79b1d458477 Tony Lindgren 2022-04-08 95
:::::: The code at line 82 was first introduced by commit
:::::: 41e79b1d458477212d0a880c87622bcaa69ab3ea clocksource/drivers/timer-ti-dm: Move inline functions to driver for am6
:::::: TO: Tony Lindgren <tony@atomide.com>
:::::: CC: Daniel Lezcano <daniel.lezcano@linaro.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-02 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 9:32 drivers/clocksource/timer-ti-dm.c:82: warning: Function parameter or member 'val' not described in 'dmtimer_write' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-08-17 11:00 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox