From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63721E75434 for ; Tue, 3 Oct 2023 07:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231231AbjJCH5P (ORCPT ); Tue, 3 Oct 2023 03:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbjJCH5O (ORCPT ); Tue, 3 Oct 2023 03:57:14 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1AE21A1 for ; Tue, 3 Oct 2023 00:57:11 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 487A080A7; Tue, 3 Oct 2023 07:57:10 +0000 (UTC) Date: Tue, 3 Oct 2023 10:57:08 +0300 From: Tony Lindgren To: Ivaylo Dimitrov Cc: daniel.lezcano@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, sean@mess.org Subject: Re: [PATCH] drivers/clocksource/timer-ti-dm: Don't call clk_get_rate() in stop function Message-ID: <20231003075708.GA34982@atomide.com> References: <1696312220-11550-1-git-send-email-ivo.g.dimitrov.75@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1696312220-11550-1-git-send-email-ivo.g.dimitrov.75@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ivaylo Dimitrov [231003 05:50]: > clk_get_rate() might sleep, and that prevents dm-timer based PWM from being > used from atomic context. > > Fix that by getting fclk rate in probe() and using a notifier in case rate > changes. Makes sense to me: Reviewed-by: Tony Lindgren