From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D532AE7AD57 for ; Tue, 3 Oct 2023 14:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238746AbjJCOPs (ORCPT ); Tue, 3 Oct 2023 10:15:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238344AbjJCOPq (ORCPT ); Tue, 3 Oct 2023 10:15:46 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 142DAB0; Tue, 3 Oct 2023 07:15:42 -0700 (PDT) Received: from wsk (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 3C32C86E23; Tue, 3 Oct 2023 16:15:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1696342539; bh=b8vXyCH/t0Phi+cqyih6SrFxJCTaRsrcH2AD1rrCm7w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vZ9My/W94LqMNkO+WaZWdB4GY63LLQLOGrjQLc+0IKDWRdkl5TlcmiwBKyU4wxF1K TeuUlAGVOOMeSJ4+d+jKDC+VZIgZ4b2pNKVKrVEbCGn9BJGCTeR0KXRhn8Tr2qIVgl Zc4g2twcWwf9CqlhOE+X0h4QWOCJ4dLmBW5dVgSzGUOAALar12ijcJACPR8PVFGkR2 nymZcXR80mu3auZj7IbEJtkGnZKLKwFK0fi1lyFC1+8t6bm9KK1wXpZkQ3jAey7CiT PPcrxiVVCvgGP3VBny64hdfbrtIrVNDo55g3gR4nZGh0hpskVKfsYeyqCXSj9aVFks RUh/VEZuGWXGg== Date: Tue, 3 Oct 2023 16:15:30 +0200 From: Lukasz Majewski To: Jakub Kicinski Cc: Vladimir Oltean , Andrew Lunn , Woojung Huh , Tristram.Ha@microchip.com, Eric Dumazet , davem@davemloft.net, Oleksij Rempel , Florian Fainelli , Paolo Abeni , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 net-next 0/5] net: dsa: hsr: Enable HSR HW offloading for KSZ9477 Message-ID: <20231003161530.462dcc48@wsk> In-Reply-To: <20231003064213.4886626f@kernel.org> References: <20230922133108.2090612-1-lukma@denx.de> <20230926225401.bganxwmtrgkiz2di@skbuf> <20230928124127.379115e6@wsk> <20231003095832.4bec4c72@wsk> <20231003104410.dhngn3vvdfdcurga@skbuf> <20231003145106.3cd5a19f@wsk> <20231003064213.4886626f@kernel.org> Organization: denx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/IeG0tTzUv6tXyyNoPLD0IVo"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/IeG0tTzUv6tXyyNoPLD0IVo Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 3 Oct 2023 06:42:13 -0700 Jakub Kicinski wrote: > On Tue, 3 Oct 2023 14:51:06 +0200 Lukasz Majewski wrote: > > I've just noticed that there is a WARNING: > > https://patchwork.kernel.org/project/netdevbpf/patch/20230922133108.209= 0612-6-lukma@denx.de/ > >=20 > > but then on the newest kernel checkpatch.pl is silent: > > ./scripts/checkpatch.pl > > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch > > total: 0 errors, 0 warnings, 0 checks, 277 lines checked > >=20 > > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch has > > no obvious style problems and is ready for submission. > >=20 > > Does the checkpatch for patchwork differs in any way from mainline? > > =20 >=20 > We run: >=20 > checkpatch with --strict --max-line-length=3D80 >=20 > https://github.com/kuba-moo/nipa/blob/master/tests/patch/checkpatch/check= patch.sh >=20 > The "multiple new lines" warning on patch 2 looks legit, no? Indeed - the: '--strict --max-line-length=3D80' makes the difference... If I may ask - why it is added? Or to ask in other way - why the "vanila" checkpatch is not enough for net-dev ? Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/IeG0tTzUv6tXyyNoPLD0IVo Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmUcIgIACgkQAR8vZIA0 zr1GBQf+PWCSC3QPDpwiT/dpPM+kFxaZl8GAWNdgvEejq+wdA93HBZEqbo31Wvc8 rFrUWCmBnC4WcReobj+knb+4kNAPxfMMwGkRq71skHnma2dDIwJuWVDLQt2LOpKd BL967/ail9sVJDKqB3bbrWiXn4UWgnn/vYdJKTE4D1zQlVnQS6+1S6cZrEMuGE+q FRab5bN4/SSGEIOGcrgo7jD6XcV75sGRi1ZaQw/kDF7/Ioc4hhxxDxo3aLQV7t3Q 6Wu2FjiUjzlM2wqhx73bbyMjBUoq3CQ6szDTZHMiUzJ/weUOpdRgZkawy46xX/9n B7cRSahymM/X3jK80qwZOI+fbpncnQ== =UMin -----END PGP SIGNATURE----- --Sig_/IeG0tTzUv6tXyyNoPLD0IVo--