public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Kai Bosch <kellerassel@gmail.com>
Cc: linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Kai Bosch <kbosch@protonmail.com>
Subject: Re: [PATCH] Firewire: IP over IEEE 1394: replaced implicit mentions of unsigned int
Date: Wed, 4 Oct 2023 13:03:49 +0900	[thread overview]
Message-ID: <20231004040349.GA53158@workstation.local> (raw)
In-Reply-To: <20231003211650.349521-1-kbosch@protonmail.com>

Hi,

Thanks for your sending the patch.

On Tue, Oct 03, 2023 at 09:16:50PM +0000, Kai Bosch wrote:
> ---
>  drivers/firewire/net.c | 48 +++++++++++++++++++++---------------------
>  1 file changed, 24 insertions(+), 24 deletions(-)
 
As long as I know, the coding style of Linux kernel[1] does not forbidden
brief expression of 'unsigned int' (= just 'unsigned'). Furthermore,
in C language specification, 'unsigned' and 'unsigned int' are the
same[2]. I have no functional change over the patch.

If the intension of patch is in the point of human readability, please
note it in the commit comment. It is the most important for the kind of
change.

I'm waiting for your next post.

[1] Linux kernel coding style
https://www.kernel.org/doc/html/v4.10/process/coding-style.html
[2] See '6.7.2 Type specifiers' in ISO/IEC 9899:1999, so called 'C99'.


Regards

Takashi Sakamoto

  reply	other threads:[~2023-10-04  4:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 21:16 [PATCH] Firewire: IP over IEEE 1394: replaced implicit mentions of unsigned int Kai Bosch
2023-10-04  4:03 ` Takashi Sakamoto [this message]
     [not found]   ` <CAM3OPxw3o7z1opx3br0296muuGphF08_qJxfY2fcQTUJVG5o2w@mail.gmail.com>
2023-10-04 16:03     ` Kai Bosch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231004040349.GA53158@workstation.local \
    --to=o-takashi@sakamocchi.jp \
    --cc=kbosch@protonmail.com \
    --cc=kellerassel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox