From: Naresh Solanki <naresh.solanki@9elements.com>
To: broonie@kernel.org, zev@bewilderbeest.net,
Liam Girdwood <lgirdwood@gmail.com>
Cc: Naresh Solanki <Naresh.Solanki@9elements.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] regulator: userspace-consumer: Retrieve supplies from DT
Date: Wed, 4 Oct 2023 14:05:27 +0200 [thread overview]
Message-ID: <20231004120529.1155700-2-naresh.solanki@9elements.com> (raw)
In-Reply-To: <20231004120529.1155700-1-naresh.solanki@9elements.com>
From: Naresh Solanki <Naresh.Solanki@9elements.com>
Instead of hardcoding a single supply, retrieve supplies from DT.
Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
---
Changes in V2:
- Use strlen for SUPPLY_SUFFIX_LEN,
- Remove bracket for single line statements in if statement.
- Remove extra space in variable declaration.
- Simplify multi line statement by calculating size in seperate
variable.
- Add function prop_supply_name & simplify code.
- Use devm_kstrdup instead to simplify code further.
- Update DT binding to align with changes.
---
drivers/regulator/userspace-consumer.c | 51 ++++++++++++++++++++++++--
1 file changed, 47 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/userspace-consumer.c b/drivers/regulator/userspace-consumer.c
index 97f075ed68c9..13c0a86ab32c 100644
--- a/drivers/regulator/userspace-consumer.c
+++ b/drivers/regulator/userspace-consumer.c
@@ -115,12 +115,41 @@ static const struct attribute_group attr_group = {
.is_visible = attr_visible,
};
+#define SUPPLY_SUFFIX "-supply"
+#define SUPPLY_SUFFIX_LEN strlen(SUPPLY_SUFFIX)
+
+static size_t prop_supply_name(char *prop_name)
+{
+ int len = strlen(prop_name);
+
+ if (len <= SUPPLY_SUFFIX_LEN)
+ return 0;
+
+ if (strcmp(prop_name + len - SUPPLY_SUFFIX_LEN, SUPPLY_SUFFIX) == 0)
+ return len - SUPPLY_SUFFIX_LEN;
+
+ return 0;
+}
+
+static int get_num_supplies(struct platform_device *pdev)
+{
+ struct property *prop;
+ int num_supplies = 0;
+
+ for_each_property_of_node(pdev->dev.of_node, prop) {
+ if (prop_supply_name(prop->name))
+ num_supplies++;
+ }
+ return num_supplies;
+}
+
static int regulator_userspace_consumer_probe(struct platform_device *pdev)
{
struct regulator_userspace_consumer_data tmpdata;
struct regulator_userspace_consumer_data *pdata;
struct userspace_consumer_data *drvdata;
- int ret;
+ struct property *prop;
+ int ret, supplies_size;
pdata = dev_get_platdata(&pdev->dev);
if (!pdata) {
@@ -131,11 +160,25 @@ static int regulator_userspace_consumer_probe(struct platform_device *pdev)
memset(pdata, 0, sizeof(*pdata));
pdata->no_autoswitch = true;
- pdata->num_supplies = 1;
- pdata->supplies = devm_kzalloc(&pdev->dev, sizeof(*pdata->supplies), GFP_KERNEL);
+ pdata->num_supplies = get_num_supplies(pdev);
+
+ supplies_size = pdata->num_supplies * sizeof(*pdata->supplies);
+ pdata->supplies = devm_kzalloc(&pdev->dev, supplies_size, GFP_KERNEL);
if (!pdata->supplies)
return -ENOMEM;
- pdata->supplies[0].supply = "vout";
+
+ for_each_property_of_node(pdev->dev.of_node, prop) {
+ const char *prop_name = prop->name;
+ size_t supply_len = prop_supply_name(prop->name);
+
+ if (!supply_len)
+ continue;
+
+ char *supply_name = devm_kstrdup(&pdev->dev, prop_name, GFP_KERNEL);
+
+ supply_name[supply_len] = '\0';
+ pdata->supplies[0].supply = supply_name;
+ }
}
if (pdata->num_supplies < 1) {
--
2.41.0
next prev parent reply other threads:[~2023-10-04 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 12:05 [PATCH 1/3] dt-bindings: regulator: regulator-output: Multiple supplies Naresh Solanki
2023-10-04 12:05 ` Naresh Solanki [this message]
2023-10-04 12:05 ` [PATCH 3/3] regulator: userspace-consumer: Update name Naresh Solanki
2023-10-04 15:14 ` [PATCH 1/3] dt-bindings: regulator: regulator-output: Multiple supplies Rob Herring
2023-10-05 7:46 ` Naresh Solanki
2023-10-05 8:41 ` Krzysztof Kozlowski
2023-10-05 11:17 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004120529.1155700-2-naresh.solanki@9elements.com \
--to=naresh.solanki@9elements.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox