From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEE9E7B5F3 for ; Wed, 4 Oct 2023 11:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242259AbjJDLcf (ORCPT ); Wed, 4 Oct 2023 07:32:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233037AbjJDLce (ORCPT ); Wed, 4 Oct 2023 07:32:34 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96A3690; Wed, 4 Oct 2023 04:32:29 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id D535160004; Wed, 4 Oct 2023 11:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696419148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jiGdNZliZJFxAotjLXsFjydngfAocFp3/JRLhQoNFiw=; b=Q2yyudk2DeopG4p/IJKJNvz/uUKI7L36/M+bfZvjO2okJ7jIuoKVMEUwQ6pbqN6uwNgGm3 ew+0dgaPuzhqPTV/Z6kO1X/4Ll3VjaXd3wP/96HWhhfZYHXlIA8Cv0pm33+uzmJoK3vJ4j 2/RCWmSDgs4fvpAl5v82tLPeg5ASmofwjH2wKpcoUUwVXaSc5Lu9NyS+mOFqKhSFUoTS7Z F1AxubzkvrfW0z+C4uKsZMNtLoDGrmNTO6i2lwKBCru+AyRMk6PtE0xfPTXMubReQ6sbte v48enjubU5DdXQYvSgeSb3GTiEV9k0fYmlUCZRskOCdk/n3bQJepsib/6BlcnQ== Date: Wed, 4 Oct 2023 13:32:25 +0200 From: Miquel Raynal To: "Rabara, Niravkumar L" Cc: Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dt-bindings: mtd: cadence: convert cadence-nand-controller.txt to yaml Message-ID: <20231004133225.4a770789@xps-13> In-Reply-To: References: <20231004061214.17176-1-niravkumar.l.rabara@intel.com> <20231004094455.1a6a19e1@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, > > > -Child nodes represent the available NAND chips. =20 > >=20 > > This is not fully pictured in the current schema, by referencing nand- > > controller.yaml I believe you allow all kind of direct partitioning (wh= ich is legacy, > > and not supposed to be supported here). > > Can you try to define a partition directly within the controller node i= n the example > > and see whether it still passes the checks? > >=20 > > Thanks, > > Miqu=C3=A8l =20 >=20 > Hi Miquel, >=20 > I tried below in the controller node in example, >=20 > ... > clocks =3D <&nf_clk>; > cdns,board-delay-ps =3D <4830>; >=20 > partition@0 { > label =3D "boot"; > reg =3D <0 0x00200000>; > }; >=20 > nand@0 { > reg =3D <0>; > }; >=20 > It shows 'partition@0' was unexpected. >=20 > DTC_CHK Documentation/devicetree/bindings/mtd/cadence,nand.example.dtb > Documentation/devicetree/bindings/mtd/cadence,nand.example.dts:35.23-38.1= 4: Warning (unique_unit_address_if_enabled): /example-0/nand-controller@10b= 80000/partition@0: duplicate unit-address (also used in node /example-0/nan= d-controller@10b80000/nand@0) > /mnt/newvolume/users/nrabara/kernel.org/3oct23/Documentation/devicetree/b= indings/mtd/cadence,nand.example.dtb: nand-controller@10b80000: Unevaluated= properties are not allowed ('partition@0' was unexpected) > From schema: /mnt/newvolume/users/nrabara/kernel.org/3oct23/Docum= entation/devicetree/bindings/mtd/cadence,nand.yaml >=20 > However using partition in nand node is OK. > nand@0 { > reg =3D <0>; > =20 > #address-cells =3D <1>; > #size-cells =3D <1>; >=20 > partition@0 { > label =3D "boot"; > reg =3D <0 0x00200000>; > }; >=20 > partition@200000 { > label =3D "env"; > reg =3D <0x00200000 0x00400000>; > }; > }; >=20 > "make dt_binding_check DT_SCHEMA_FILES=3Dmtd/cadence,nand.yaml" is OK wi= thout any warnings.=20 >=20 > DTEX Documentation/devicetree/bindings/mtd/cadence,nand.example.dts > DTC_CHK Documentation/devicetree/bindings/mtd/cadence,nand.example.dtb >=20 > Any additional changes required for this patch? No, should be fine then. Thanks, Miqu=C3=A8l