From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A415E7C4D4 for ; Wed, 4 Oct 2023 15:23:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243219AbjJDPXE (ORCPT ); Wed, 4 Oct 2023 11:23:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243221AbjJDPXC (ORCPT ); Wed, 4 Oct 2023 11:23:02 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB302D7 for ; Wed, 4 Oct 2023 08:22:57 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qo3i3-0002p0-Lg; Wed, 04 Oct 2023 17:22:47 +0200 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qo3i1-00B3vw-5O; Wed, 04 Oct 2023 17:22:45 +0200 Received: from mtr by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qo3i1-00Cmdh-0E; Wed, 04 Oct 2023 17:22:45 +0200 Date: Wed, 4 Oct 2023 17:22:44 +0200 From: Michael Tretter To: Adam Ford Cc: Inki Dae , Neil Armstrong , Robert Foss , Jonas Karlman , dri-devel@lists.freedesktop.org, Laurent Pinchart , Marco Felsch , Jernej Skrabec , linux-kernel@vger.kernel.org, Jagan Teki , Andrzej Hajda , kernel@pengutronix.de, Marek Szyprowski Subject: Re: [PATCH 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information Message-ID: <20231004152244.GD3042281@pengutronix.de> References: <20230818-samsung-dsim-v1-0-b39716db6b7a@pengutronix.de> <20230818-samsung-dsim-v1-1-b39716db6b7a@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Sep 2023 07:47:53 -0500, Adam Ford wrote: > On Sun, Sep 3, 2023 at 8:05 PM Inki Dae wrote: > > > > 2023년 8월 29일 (화) 오전 7:38, Adam Ford 님이 작성: > > > > > > On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter > > > wrote: > > > > > > > > From: Marco Felsch > > > > > > > > Since the MIPI configuration can be changed on demand it is very useful > > > > to print more MIPI settings during the MIPI device attach step. > > > > > > > > Signed-off-by: Marco Felsch > > > > Signed-off-by: Michael Tretter > > > > > > Reviewed-by: Adam Ford #imx8mm-beacon > > > Tested-by: Adam Ford #imx8mm-beacon > > > > Reviewed-by: Inki Dae > > Acked-by: Inki Dae > > What needs to be done in order to get this accepted? This series is a > very nice improvement in i.MX8M Mini / Nano. I think it is my turn to send a v2 that addresses the review comments. I'll try to find time this week. Michael > > adam > > > > > > > > > --- > > > > drivers/gpu/drm/bridge/samsung-dsim.c | 5 ++++- > > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c > > > > index 73ec60757dbc..6778f1751faa 100644 > > > > --- a/drivers/gpu/drm/bridge/samsung-dsim.c > > > > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c > > > > @@ -1711,7 +1711,10 @@ static int samsung_dsim_host_attach(struct mipi_dsi_host *host, > > > > return ret; > > > > } > > > > > > > > - DRM_DEV_INFO(dev, "Attached %s device\n", device->name); > > > > + DRM_DEV_INFO(dev, "Attached %s device (lanes:%d bpp:%d mode-flags:0x%lx)\n", > > > > + device->name, device->lanes, > > > > + mipi_dsi_pixel_format_to_bpp(device->format), > > > > + device->mode_flags); > > > > > > > > drm_bridge_add(&dsi->bridge); > > > > > > > > > > > > -- > > > > 2.39.2 > > > > >