From: Greg KH <gregkh@linuxfoundation.org>
To: Zhenhua Huang <quic_zhenhuah@quicinc.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
quic_pkondeti@quicinc.com, quic_tingweiz@quicinc.com,
saravanak@google.com
Subject: Re: [RESEND PATCH] driver core: Clear FWNODE_FLAG_LINKS_ADDED in device_links_purge()
Date: Thu, 5 Oct 2023 11:32:22 +0200 [thread overview]
Message-ID: <2023100501-entourage-bounce-3364@gregkh> (raw)
In-Reply-To: <1695781810-5700-1-git-send-email-quic_zhenhuah@quicinc.com>
On Wed, Sep 27, 2023 at 10:30:10AM +0800, Zhenhua Huang wrote:
> Flag FWNODE_FLAG_LINKS_ADDED stops fwnode links creation. Current kernel
> only adds it once after fwnode links creation in fw_devlink_parse_fwnode().
> After that even device links being purged, the flag will not be cleared.
>
> Fwnode links are converted to device links and will not be added back
> forever in normal case. Essentially if a device is registered and
> unregisted (also deleted) before it is probed (due to missing fwlink
> dependencies, abort in device_links_check_suppliers), the fwlink is not
> setup next when device is newly created again. This means the probe gets
> called without meeting all dependencies.
>
> It usuallly happens in the case of a glue driver.
What exact glue driver is causing this to happen? Why can't we fix that
up instead?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-05 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 2:30 [RESEND PATCH] driver core: Clear FWNODE_FLAG_LINKS_ADDED in device_links_purge() Zhenhua Huang
2023-09-27 5:57 ` Greg KH
2023-09-27 6:32 ` Zhenhua Huang
2023-09-27 8:08 ` Greg KH
2023-09-27 5:57 ` Greg KH
2023-09-27 6:34 ` Zhenhua Huang
2023-09-27 8:08 ` Greg KH
2023-09-27 9:53 ` Zhenhua Huang
2023-10-02 21:40 ` Saravana Kannan
2023-10-03 3:34 ` Pavan Kondeti
2023-10-05 9:32 ` Greg KH [this message]
2023-10-05 10:49 ` Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100501-entourage-bounce-3364@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_zhenhuah@quicinc.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox