From: Jakub Kicinski <kuba@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sgoutham@marvell.com>, <gakula@marvell.com>,
<sbhatta@marvell.com>, <hkelam@marvell.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<hawk@kernel.org>, <alexander.duyck@gmail.com>,
<ilias.apalodimas@linaro.org>, <linyunsheng@huawei.com>,
<bigeasy@linutronix.de>
Subject: Re: [PATCH net v1] octeontx2-pf: Fix page pool frag allocation failure.
Date: Thu, 5 Oct 2023 09:21:45 -0700 [thread overview]
Message-ID: <20231005092145.08cc84fb@kernel.org> (raw)
In-Reply-To: <20231005021434.3427404-1-rkannoth@marvell.com>
On Thu, 5 Oct 2023 07:44:34 +0530 Ratheesh Kannoth wrote:
> + sz = PAGE_ALIGN(ALIGN(SKB_DATA_ALIGN(buf_size), OTX2_ALIGN));
> + pp_params.order = get_order(sz);
Surely get_order() rounds up by itself otherwise all callers would
have to do the PAGE_ALIGN()...
--
pw-bot: cr
next prev parent reply other threads:[~2023-10-05 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 2:14 [PATCH net v1] octeontx2-pf: Fix page pool frag allocation failure Ratheesh Kannoth
2023-10-05 16:21 ` Jakub Kicinski [this message]
2023-10-06 2:55 ` [EXT] " Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005092145.08cc84fb@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hawk@kernel.org \
--cc=hkelam@marvell.com \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).