From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tina Zhang <tina.zhang@intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Michael Shavit <mshavit@google.com>,
Vasant Hegde <vasant.hegde@amd.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/6] iommu: Introduce mm_get_pasid() helper function
Date: Thu, 5 Oct 2023 15:44:04 -0300 [thread overview]
Message-ID: <20231005184404.GT13795@ziepe.ca> (raw)
In-Reply-To: <20230925023813.575016-4-tina.zhang@intel.com>
On Mon, Sep 25, 2023 at 10:38:10AM +0800, Tina Zhang wrote:
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index a4eab6697fe1..db2510da28c1 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -1189,10 +1189,14 @@ static inline bool mm_valid_pasid(struct mm_struct *mm)
> {
> return mm->pasid != IOMMU_PASID_INVALID;
> }
> -static inline u32 mm_get_enqcmd_pasid(struct mm_struct *mm)
> +static inline u32 mm_get_pasid(struct mm_struct *mm)
This should not be in a global header
Put the mm_get_pasid() in iommu-sva.c as a helper
Have SMMUv3 call mm_get_enqcmd_pasid() for now, it will be fixed
There is no "mm_pasid" that should leak outside of iommu-sva.c except
specifically to support enqcmd.
Jason
next prev parent reply other threads:[~2023-10-05 18:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 2:38 [PATCH v5 0/6] Share sva domains with all devices bound to a mm Tina Zhang
2023-09-25 2:38 ` [PATCH v5 1/6] iommu/vt-d: Remove mm->pasid in intel_sva_bind_mm() Tina Zhang
2023-09-25 2:38 ` [PATCH v5 2/6] iommu: Add mm_get_enqcmd_pasid() helper function Tina Zhang
2023-10-05 18:40 ` Jason Gunthorpe
2023-09-25 2:38 ` [PATCH v5 3/6] iommu: Introduce mm_get_pasid() " Tina Zhang
2023-10-05 18:44 ` Jason Gunthorpe [this message]
2023-09-25 2:38 ` [PATCH v5 4/6] mm: Add structure to keep sva information Tina Zhang
2023-10-05 18:49 ` Jason Gunthorpe
2023-09-25 2:38 ` [PATCH v5 5/6] iommu: Support mm PASID 1:n with sva domains Tina Zhang
2023-10-05 18:49 ` Jason Gunthorpe
2023-10-06 8:07 ` Nicolin Chen
2023-10-10 11:21 ` Tina Zhang
2023-10-11 7:07 ` Zhang, Tina
2023-10-06 18:06 ` Jason Gunthorpe
2023-10-10 13:38 ` Zhang, Tina
2023-09-25 2:38 ` [PATCH v5 6/6] mm: Deprecate pasid field Tina Zhang
2023-10-05 18:50 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005184404.GT13795@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=tina.zhang@intel.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox