From: Benedikt Spranger <b.spranger@linutronix.de>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Dinh Nguyen <dinguyen@kernel.org>
Subject: Re: [PATCH 1/1] clk: socfpga: gate: Fix of by factor 2 for serial console
Date: Fri, 6 Oct 2023 05:39:06 +0200 [thread overview]
Message-ID: <20231006053906.1bb2a7d8@mitra> (raw)
In-Reply-To: <77d94f6a6a4b45f8ad711f52ca6ba86c.sboyd@kernel.org>
On Thu, 05 Oct 2023 14:03:19 -0700
Stephen Boyd <sboyd@kernel.org> wrote:
> What's your analysis?
Commit 9607beb917df ("clk: socfpga: gate: Add a determine_rate hook")
breaks serial console output and changing the determine_rate hook to
__clk_mux_determine_rate() fix the issue.
> Does this patch also fix it?
>
> ---8<---
> diff --git a/drivers/clk/socfpga/clk-gate.c
> b/drivers/clk/socfpga/clk-gate.c index 8dd601bd8538..b3400d2d8128
> 100644 --- a/drivers/clk/socfpga/clk-gate.c
> +++ b/drivers/clk/socfpga/clk-gate.c
> @@ -173,6 +173,7 @@ void __init socfpga_gate_init(struct device_node
> *node) if (init.num_parents < 2) {
> ops->get_parent = NULL;
> ops->set_parent = NULL;
> + ops->determine_rate = NULL;
> }
>
> init.parent_names = parent_name;
No. serial console is broken too.
Regards
Benedikt Spranger
next prev parent reply other threads:[~2023-10-06 3:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 9:59 [PATCH 0/1] Broken serial console on Altera Cyclon V board Benedikt Spranger
2023-10-05 9:59 ` [PATCH 1/1] clk: socfpga: gate: Fix of by factor 2 for serial console Benedikt Spranger
2023-10-05 11:34 ` Maxime Ripard
2023-10-05 18:32 ` Benedikt Spranger
2023-10-05 21:03 ` Stephen Boyd
2023-10-06 3:39 ` Benedikt Spranger [this message]
2023-10-06 14:53 ` Maxime Ripard
2023-10-06 15:01 ` Maxime Ripard
2023-10-06 16:40 ` Benedikt Spranger
2023-10-11 9:17 ` Maxime Ripard
2023-10-11 14:03 ` Benedikt Spranger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006053906.1bb2a7d8@mitra \
--to=b.spranger@linutronix.de \
--cc=dinguyen@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox