From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07655E92FE4 for ; Fri, 6 Oct 2023 06:06:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230164AbjJFGGq (ORCPT ); Fri, 6 Oct 2023 02:06:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbjJFGGp (ORCPT ); Fri, 6 Oct 2023 02:06:45 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E19690; Thu, 5 Oct 2023 23:06:42 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qodyp-0006fE-FF; Fri, 06 Oct 2023 08:06:31 +0200 Date: Fri, 6 Oct 2023 08:06:31 +0200 From: Florian Westphal To: Henrik =?iso-8859-15?Q?Lindstr=F6m?= Cc: Florian Westphal , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: macvtap performs IP defragmentation, causing MTU problems for virtual machines Message-ID: <20231006060631.GC11420@breakpoint.cc> References: <2197902.NgBsaNRSFp@pc> <20231004080037.GC15013@breakpoint.cc> <3259970.44csPzL39Z@pc> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3259970.44csPzL39Z@pc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Henrik Lindström wrote: > On onsdag 4 oktober 2023 10:00:37 CEST Florian Westphal wrote: > > Can you submit this formally, with proper changelog and Signed-off-by? > > See scripts/checkpatch.pl in the kernel tree. > Sure, i can give it a shot. How do i properly credit you if i submit your > patch with some small changes of my own? You can use: "Suggested-by:" tag here. > > You could also mention in changelog that this is ipv4 only because > > ipv6 already considers the interface index during reassembly. > Interesting. I've been trying to understand the code and it seems like > ipv6 does defragmentation per-interface, while ipv4 does it "per-vrf" > (correct me if i'm wrong). Is there any reason for this difference? Only for linklocal and multicasts. Added in 264640fc2c5f4f913db5c73fa3eb1ead2c45e9d7 . Even mentions macvlan in the changelog. > The idea being that bcast/mcast packets are always defragmented > per-interface, and unicast packets always "per-vrf". LGTM, but please CC dsahern@kernel.org once you submit the patch.