public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Valentin Schneider <vschneid@redhat.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 2/3] sched/nohz: Use consistent variable names in find_new_ilb() and kick_ilb()
Date: Fri,  6 Oct 2023 12:25:17 +0200	[thread overview]
Message-ID: <20231006102518.2452758-3-mingo@kernel.org> (raw)
In-Reply-To: <20231006102518.2452758-1-mingo@kernel.org>

Use 'ilb_cpu' consistently in both functions.

Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org
---
 kernel/sched/fair.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8435179779e3..d4e90d15bd77 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -11558,18 +11558,18 @@ static inline int on_null_domain(struct rq *rq)
  */
 static inline int find_new_ilb(void)
 {
-	int ilb;
 	const struct cpumask *hk_mask;
+	int ilb_cpu;
 
 	hk_mask = housekeeping_cpumask(HK_TYPE_MISC);
 
-	for_each_cpu_and(ilb, nohz.idle_cpus_mask, hk_mask) {
+	for_each_cpu_and(ilb_cpu, nohz.idle_cpus_mask, hk_mask) {
 
-		if (ilb == smp_processor_id())
+		if (ilb_cpu == smp_processor_id())
 			continue;
 
-		if (idle_cpu(ilb))
-			return ilb;
+		if (idle_cpu(ilb_cpu))
+			return ilb_cpu;
 	}
 
 	return nr_cpu_ids;
-- 
2.39.2


  parent reply	other threads:[~2023-10-06 10:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06 10:25 [PATCH 0/3] sched/nohz: Misc minor cleanups to the NOHZ idle balancing code Ingo Molnar
2023-10-06 10:25 ` [PATCH 1/3] sched/nohz: Update idle load-balancing (ILB) comments Ingo Molnar
2023-10-09 10:26   ` [tip: sched/core] " tip-bot2 for Ingo Molnar
2023-10-09 15:12   ` [PATCH 1/3] " Valentin Schneider
2023-10-06 10:25 ` Ingo Molnar [this message]
2023-10-09 10:26   ` [tip: sched/core] sched/nohz: Use consistent variable names in find_new_ilb() and kick_ilb() tip-bot2 for Ingo Molnar
2023-10-09 15:12   ` [PATCH 2/3] " Valentin Schneider
2023-10-06 10:25 ` [PATCH 3/3] sched/nohz: Remove weird error handling from find_new_ilb() Ingo Molnar
2023-10-06 10:38   ` Peter Zijlstra
2023-10-06 11:01     ` Ingo Molnar
2023-10-09 15:11       ` Valentin Schneider
2023-10-09 10:26   ` [tip: sched/core] sched/nohz: Remove unnecessarily complex error handling pattern " tip-bot2 for Ingo Molnar
2023-10-08 16:56 ` [PATCH 0/3] sched/nohz: Misc minor cleanups to the NOHZ idle balancing code Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006102518.2452758-3-mingo@kernel.org \
    --to=mingo@kernel.org \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=frederic@kernel.org \
    --cc=joel@joelfernandes.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox