From: Peter Zijlstra <peterz@infradead.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
x86@kernel.org
Subject: Re: [tip: locking/core] locking/futex/selftests: Remove duplicate ABI defines
Date: Fri, 6 Oct 2023 13:12:28 +0200 [thread overview]
Message-ID: <20231006111228.GD36277@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <1b9a4e52-cfa3-4f56-b259-41c94abed362@collabora.com>
On Fri, Oct 06, 2023 at 04:05:31PM +0500, Muhammad Usama Anjum wrote:
> cd /linux_mainline/tools/testing/selftests/../../..
That's very odd way of writing:
cd /linux_mainline/
> make headers
This does a build without O=, I can't do that.
As in, one must not mix O= and non O= builds, and since I have a ton of
O= output dirs on, I simply can't do this.
> make: *** [../../lib.mk:81: kernel_header_files] Error 1
> ➜ functional (06bc8fe4bfc4b) ✗ (cd $mainline && make headers) > /dev/null
> ➜ functional (06bc8fe4bfc4b) ✗ make
> gcc -g -O2 -Wall -D_GNU_SOURCE -pthread -I../include -I../../
> futex_wait_timeout.c -lpthread -lrt -o
> /linux_mainline/tools/testing/selftests/futex/functional/futex_wait_timeout
root@noisy:/usr/src/linux-2.6# cd tools/testing/selftests/futex/functional/
root@noisy:/usr/src/linux-2.6/tools/testing/selftests/futex/functional# make
gcc -g -O2 -Wall -D_GNU_SOURCE -pthread -I../include -I../../ futex_wait_timeout.c -lpthread -lrt -o /mnt/hirez/usr/src/linux-2.6/tools/testing/selftests/futex/functional/futex_wait_timeout
In file included from futex_wait_timeout.c:20:
../include/futex2test.h:18:47: warning: ‘struct futex_waitv’ declared inside parameter list will not be visible outside of this definition or declaration
18 | static inline int futex_waitv(volatile struct futex_waitv *waiters, unsigned long nr_waiters,
Because noisy runs a really old userspace (buster)..
next prev parent reply other threads:[~2023-10-06 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 9:55 [PATCH v2] selftests: futex: remove duplicate unneeded defines Muhammad Usama Anjum
2023-10-06 10:32 ` [tip: locking/core] locking/futex/selftests: Remove duplicate ABI defines tip-bot2 for Muhammad Usama Anjum
2023-10-06 10:43 ` Peter Zijlstra
2023-10-06 10:57 ` Ingo Molnar
2023-10-06 11:04 ` Ingo Molnar
2023-10-06 11:05 ` Muhammad Usama Anjum
2023-10-06 11:12 ` Peter Zijlstra [this message]
2023-10-06 11:17 ` Peter Zijlstra
2023-10-06 11:13 ` Peter Zijlstra
2023-10-16 19:21 ` [PATCH v2] selftests: futex: remove duplicate unneeded defines Shuah Khan
2023-10-16 21:43 ` Peter Zijlstra
2023-10-18 19:11 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006111228.GD36277@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=usama.anjum@collabora.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox