From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Igor Artemiev <Igor.A.Artemiev@mcst.ru>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [lvc-project] [PATCH] staging: rtl8712: fix buffer overflow in r8712_xmitframe_complete()
Date: Fri, 6 Oct 2023 15:37:40 +0200 [thread overview]
Message-ID: <2023100645-vicinity-nuclei-3d84@gregkh> (raw)
In-Reply-To: <20230919092318.14837-1-Igor.A.Artemiev@mcst.ru>
On Tue, Sep 19, 2023 at 12:23:18PM +0300, Igor Artemiev wrote:
> The value of pxmitframe->attrib.priority in r8712_issue_addbareq_cmd(),
> which dump_xframe() calls, is used to calculate the index for accessing
> an array of size 16. The value of pxmitframe->attrib.priority can be
> greater than 15, because the r8712_update_attrib() function can write
> a value up to 31 to attrib.priority, and r8712_xmitframe_complete()
> checks that pxmitframe->attrib.priority is less than 16 before
> calling r8712_xmitframe_coalesce().
But that number comes from the hardware, so how can it ever be larger
than 15?
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
How was this tested to verify that it can be triggered and that this
change solves anything?
You have read the kernel documentation for what is required when using
"research tools" like this, right?
thanks,
greg k-h
prev parent reply other threads:[~2023-10-06 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 9:23 [lvc-project] [PATCH] staging: rtl8712: fix buffer overflow in r8712_xmitframe_complete() Igor Artemiev
2023-10-06 13:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100645-vicinity-nuclei-3d84@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Igor.A.Artemiev@mcst.ru \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox