public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: "Andrew Davis" <afd@ti.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: dts: omap: Apply am57xx-idk overlays to base dtbs
Date: Sat, 7 Oct 2023 09:51:06 +0300	[thread overview]
Message-ID: <20231007065106.GO34982@atomide.com> (raw)
In-Reply-To: <CAL_Jsq+8jisrwEqzz7tZnsV9g2+LmThwpO7sHRFA-zh+6q8XuA@mail.gmail.com>

* Rob Herring <robh@kernel.org> [230922 16:23]:
> On Fri, Sep 22, 2023 at 9:38 AM Andrew Davis <afd@ti.com> wrote:
> >
> > On 9/12/23 1:59 AM, Tony Lindgren wrote:
> > > * Rob Herring <robh@kernel.org> [230911 21:46]:
> > >> DT overlays in tree need to be applied to a base DTB to validate they
> > >> apply, to run schema checks on them, and to catch any errors at compile
> > >> time.
> > >>
> > >> Signed-off-by: Rob Herring <robh@kernel.org>
> > >> ---
> > >> Note that I have no idea if this combination of overlays makes sense.
> > >
> >
> > It does make sense, but it is only one of many valid combinations. I'm
> > guessing the goal here is just to make sure they all get applied in
> > at least one way so the scheme check runs. In that case this is fine
> > other than it might give the impression this is the only valid combinations.
> 
> I only care that an overlay is applied to one base. You should care
> about any combination a user might do in a bootloader because who
> wants to debug a failure a) on a board and b) in the bootloader.
> 
> > Also now we end up with these odd `am57{1,2}x-idk-overlays.dtb` files
> > which also might confuse folks, I wonder if there is some way to
> > apply and check, but not ship/install these..
> 
> There's already a config option, CONFIG_OF_ALL_DTBS, which adds
> $(dtb-) entries to the build. So if you have "dtb- +=
> foo-overlays.dtb" it will only be built in that case. Note that they'd
> probably get installed too, but who installs allyesconfig builds.

So what's the conclusion here? Is this safe to apply yes or no?

Regards,

Tony



      reply	other threads:[~2023-10-07  6:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 21:46 [PATCH] arm: dts: omap: Apply am57xx-idk overlays to base dtbs Rob Herring
2023-09-12  6:59 ` Tony Lindgren
2023-09-22 14:38   ` Andrew Davis
2023-09-22 16:23     ` Rob Herring
2023-10-07  6:51       ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231007065106.GO34982@atomide.com \
    --to=tony@atomide.com \
    --cc=afd@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox