Re: [PATCH] KVM: deprecate KVM_WERROR in favor of general WERROR

Kees Cook
2023-10-09T17:18:26Z

On Fri, Oct 06, 2023 at 01:54:15PM -0700, Jakub Kicinski wrote:
> Setting WERROR for random subsystems make life really hard
> for subsystems which want to build-test their stuff with W=1.
> WERROR for the entire kernel now exists and can be used
> instead. W=1 people probably know how to deal with the global
> W=1 already, tracking all per-subsystem WERRORs is too much...
>
> Link: https://lore.kernel.org/all/0da9874b6e9fcbaaa5edeb345d7e2a7c859fc818.1696271334.git.thomas.lendacky@amd.com/
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Yeah, best to have just the global option.

Reviewed-by: Kees Cook <keescook@chromium.org>

--
Kees Cook