From: Peter Zijlstra <peterz@infradead.org>
To: brookxu <brookxu.cn@gmail.com>
Cc: bsingharora@gmail.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] delayacct: convert task->delays to a object
Date: Mon, 9 Oct 2023 16:18:41 +0200 [thread overview]
Message-ID: <20231009141841.GF14330@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <b1258877-4d02-67d9-a2db-d510eadf8441@gmail.com>
On Mon, Oct 09, 2023 at 07:38:58PM +0800, brookxu wrote:
> I found another question when I tried to allocate task_delay_info on demand,
> it is hard for us to
>
> determine whether tsk->delays is NULL due to memory failure or delayacct
> disabled, if due to
>
> memory failure I think we should not try to allocate it again, otherwise we
> may have performance
>
> issues, such as following code. If we limit only try once, the code is very
> trick..
Yeah, I wouldn't worry about that. Not until it's shown to be a real
issue. First do the simple thing, only make it more complicated if
there's a real need.
next prev parent reply other threads:[~2023-10-09 14:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 10:49 [PATCH 0/3] delayacct: optimization & code simplify brookxu.cn
2023-10-08 10:49 ` [PATCH 1/3] delayacct: introduce delayacct_enabled() to simplify implement brookxu.cn
2023-10-08 10:56 ` Peter Zijlstra
2023-10-08 11:03 ` brookxu
2023-10-08 10:49 ` [PATCH 2/3] delayacct: convert task->delays to a object brookxu.cn
2023-10-08 10:58 ` Peter Zijlstra
2023-10-08 11:10 ` brookxu
2023-10-09 8:43 ` Peter Zijlstra
2023-10-09 10:29 ` brookxu
2023-10-09 14:17 ` Peter Zijlstra
2023-10-09 11:38 ` brookxu
2023-10-09 14:18 ` Peter Zijlstra [this message]
2023-10-08 13:42 ` kernel test robot
2023-10-08 15:47 ` kernel test robot
2023-10-08 16:18 ` kernel test robot
2023-10-08 10:49 ` [PATCH 3/3] delayacct: remove delayacct_on to simplify the code brookxu.cn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009141841.GF14330@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=brookxu.cn@gmail.com \
--cc=bsingharora@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox