From: Peter Zijlstra <peterz@infradead.org>
To: Chen Yu <yu.c.chen@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Phil Auld <pauld@redhat.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org, Tim Chen <tim.c.chen@intel.com>,
Chen Yu <yu.chen.surf@gmail.com>
Subject: Re: [PATCH] sched/fair: Use printk_deferred instead of printk in pick_eevdf()
Date: Tue, 10 Oct 2023 09:59:28 +0200 [thread overview]
Message-ID: <20231010075928.GA377@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20231010032541.339606-1-yu.c.chen@intel.com>
On Tue, Oct 10, 2023 at 11:25:41AM +0800, Chen Yu wrote:
> When no eligible entity is found in pick_eevdf(), it has to pick
> the entity with smallest vruntime. This indicates a potential issue
> and scheduler will print this error.
>
> However this printk could introduce possible circular locking issue
> because when the code path reaches here with the rq lock held, the
> printk could trigger further scheduling which loops back to the
> scheduler.
>
> Use printk_deferred() to defer the console write from current context
> to the irq work in the next tick.
No.. I detest printk_deferred with a passion. This is effectively a WARN
and we don't do silly buggers for them either.
next prev parent reply other threads:[~2023-10-10 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 3:25 [PATCH] sched/fair: Use printk_deferred instead of printk in pick_eevdf() Chen Yu
2023-10-10 7:59 ` Peter Zijlstra [this message]
2023-10-10 12:26 ` Phil Auld
2023-10-10 14:12 ` Peter Zijlstra
2023-10-11 10:27 ` Chen Yu
2023-10-11 10:30 ` Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010075928.GA377@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=tim.c.chen@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=yu.c.chen@intel.com \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox