From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF5F3CD8C80 for ; Tue, 10 Oct 2023 14:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232455AbjJJONi (ORCPT ); Tue, 10 Oct 2023 10:13:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232377AbjJJONg (ORCPT ); Tue, 10 Oct 2023 10:13:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E46A99; Tue, 10 Oct 2023 07:13:35 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7137C433C8; Tue, 10 Oct 2023 14:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696947214; bh=KIqXX4dScRrMHwDEzF9HKKvrsZlOHXBbgzmnWEUCjS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XEHObZT75+L1jmoh5G9m7XnfTcOOAxhRfyMvP8nP2AhwGLM2Z3nWi+bqPqyXYDZIF MOMAaN4RmzkhT5Mo20ctRVu2rFHPLt82ZTsWdCPfCQVpXEJyZW0+SsjZx5nlj54fM5 tLM6psgJmcYdHFtKo4s5xqFHB4vj172dtJVNp9Oe3zMqmEXd7yKBqNn3XzsoJ2saSS WuiP+dWTz2DdKnYD4uLzfAKqXcYSIiLZugwFURwEPedTAfB9RnHluNTOEJmsOIQdub /In7pR8xpziE4b+EKSX7EhdurOLxkXEZULdYhUQVZSynXEhp4WJu72kmXXRuWZZBnI k1D9a2w45nFwg== Received: (nullmailer pid 762988 invoked by uid 1000); Tue, 10 Oct 2023 14:13:32 -0000 Date: Tue, 10 Oct 2023 09:13:32 -0500 From: Rob Herring To: Dmitry Rokosov Cc: lee@kernel.org, pavel@ucw.cz, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andy.shevchenko@gmail.com, kernel@sberdevices.ru, rockosov@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v1 04/11] dt-bindings: leds: aw200xx: introduce optional hwen-gpio property Message-ID: <20231010141332.GA756597-robh@kernel.org> References: <20231006160437.15627-1-ddrokosov@salutedevices.com> <20231006160437.15627-5-ddrokosov@salutedevices.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006160437.15627-5-ddrokosov@salutedevices.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 06, 2023 at 07:04:30PM +0300, Dmitry Rokosov wrote: > Property 'awinic,hwen-gpio' is optional, it can be used by the board > developer to connect AW200XX LED controller with appropriate poweron > GPIO pad. > > Signed-off-by: Dmitry Rokosov > --- > Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml > index 73b81f7a7258..e3ad11fc7a84 100644 > --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml > +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml > @@ -41,6 +41,9 @@ properties: > description: > Leds matrix size > > + awinic,hwen-gpio: > + maxItems: 1 We have standard 'enable-gpios' or 'powerdown-gpios'. Those don't work here? Note that *-gpio is deprecated in favor of *-gpios. > + > patternProperties: > "^led@[0-9a-f]+$": > type: object > @@ -90,12 +93,15 @@ additionalProperties: false > > examples: > - | > + #include > #include > > i2c { > #address-cells = <1>; > #size-cells = <0>; > > + awinic,hwen-gpio = <&gpio 3 GPIO_ACTIVE_HIGH>; > + > led-controller@3a { > compatible = "awinic,aw20036"; > reg = <0x3a>; > -- > 2.36.0 >