[PATCH 0/2] MIPS: lantic: Fix "no prototype" warning

[PATCH 0/2] MIPS: lantic: Fix "no prototype" warning

[Bjorn Helgaas]

From: Bjorn Helgaas <bhelgaas@google.com>

Fix a "no prototype" warning found by the kernel test robot.

Bjorn Helgaas (2):
  MIPS: lantic: Fix pcibios_plat_dev_init() "no previous prototype"
    warning
  MIPS: lantic: Remove unnecessary include of <linux/of_irq.h>

 arch/mips/pci/fixup-lantiq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.34.1

[PATCH 1/2] MIPS: lantic: Fix pcibios_plat_dev_init() "no previous prototype" warning

[Bjorn Helgaas]

From: Bjorn Helgaas <bhelgaas@google.com>

After bbd8810d3998 ("PCI: Remove unused includes and superfluous struct
declaration"), <linux/of_pci.h> no longer includes <linux/pci.h>, which
provides the extern declarations for pcibios_plat_dev_init() and
pcibios_map_irq() via <asm/pci.h>.

This results in these new warnings:

  arch/mips/pci/fixup-lantiq.c:13:5: warning: no previous prototype for 'pcibios_plat_dev_init' [-Wmissing-prototypes]
  arch/mips/pci/fixup-lantiq.c:24:5: warning: no previous prototype for 'pcibios_map_irq' [-Wmissing-prototypes]

Include <linux/pci.h> directly to get these declarations.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310070445.tzRBNYRC-lkp@intel.com/
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/mips/pci/fixup-lantiq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/pci/fixup-lantiq.c b/arch/mips/pci/fixup-lantiq.c
index 105569c1b712..8f5fb98b3984 100644
--- a/arch/mips/pci/fixup-lantiq.c
+++ b/arch/mips/pci/fixup-lantiq.c
@@ -6,6 +6,7 @@
 
 #include <linux/of_irq.h>
 #include <linux/of_pci.h>
+#include <linux/pci.h>
 
 int (*ltq_pci_plat_arch_init)(struct pci_dev *dev) = NULL;
 int (*ltq_pci_plat_dev_init)(struct pci_dev *dev) = NULL;
-- 
2.34.1

Re: [PATCH 1/2] MIPS: lantic: Fix pcibios_plat_dev_init() "no previous prototype" warning

[Philippe Mathieu-Daudé]

On 10/10/23 16:34, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> After bbd8810d3998 ("PCI: Remove unused includes and superfluous struct
> declaration"), <linux/of_pci.h> no longer includes <linux/pci.h>, which
> provides the extern declarations for pcibios_plat_dev_init() and
> pcibios_map_irq() via <asm/pci.h>.
> 
> This results in these new warnings:
> 
>    arch/mips/pci/fixup-lantiq.c:13:5: warning: no previous prototype for 'pcibios_plat_dev_init' [-Wmissing-prototypes]
>    arch/mips/pci/fixup-lantiq.c:24:5: warning: no previous prototype for 'pcibios_map_irq' [-Wmissing-prototypes]
> 
> Include <linux/pci.h> directly to get these declarations.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310070445.tzRBNYRC-lkp@intel.com/
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>   arch/mips/pci/fixup-lantiq.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[PATCH 2/2] MIPS: lantic: Remove unnecessary include of <linux/of_irq.h>

[Bjorn Helgaas]

From: Bjorn Helgaas <bhelgaas@google.com>

arch/mips/pci/fixup-lantiq.c requires nothing from <linux/of_irq.h>, so
remove the include of it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/mips/pci/fixup-lantiq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/pci/fixup-lantiq.c b/arch/mips/pci/fixup-lantiq.c
index 8f5fb98b3984..13009666204f 100644
--- a/arch/mips/pci/fixup-lantiq.c
+++ b/arch/mips/pci/fixup-lantiq.c
@@ -4,7 +4,6 @@
  *  Copyright (C) 2012 John Crispin <john@phrozen.org>
  */
 
-#include <linux/of_irq.h>
 #include <linux/of_pci.h>
 #include <linux/pci.h>
 
-- 
2.34.1

Re: [PATCH 2/2] MIPS: lantic: Remove unnecessary include of <linux/of_irq.h>

[Philippe Mathieu-Daudé]

On 10/10/23 16:34, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> arch/mips/pci/fixup-lantiq.c requires nothing from <linux/of_irq.h>, so
> remove the include of it.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>   arch/mips/pci/fixup-lantiq.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/pci/fixup-lantiq.c b/arch/mips/pci/fixup-lantiq.c
> index 8f5fb98b3984..13009666204f 100644
> --- a/arch/mips/pci/fixup-lantiq.c
> +++ b/arch/mips/pci/fixup-lantiq.c
> @@ -4,7 +4,6 @@
>    *  Copyright (C) 2012 John Crispin <john@phrozen.org>
>    */
>   
> -#include <linux/of_irq.h>
>   #include <linux/of_pci.h>

Indeed, we are good with <linux/of_pci.h>.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 0/2] MIPS: lantic: Fix "no prototype" warning

[Thomas Bogendoerfer]

On Tue, Oct 10, 2023 at 09:34:04AM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Fix a "no prototype" warning found by the kernel test robot.
> 
> Bjorn Helgaas (2):
>   MIPS: lantic: Fix pcibios_plat_dev_init() "no previous prototype"
>     warning
>   MIPS: lantic: Remove unnecessary include of <linux/of_irq.h>
> 
>  arch/mips/pci/fixup-lantiq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-nextr. I've fixed lantic -> lantiq while applying.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]