Re: [PATCH 1/2] MIPS: lantic: Fix pcibios_plat_dev_init() "no previous prototype" warning

Philippe Mathieu-Daudé
2023-10-12T08:26:14Z

On 10/10/23 16:34, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> After bbd8810d3998 ("PCI: Remove unused includes and superfluous struct
> declaration"), <linux/of_pci.h> no longer includes <linux/pci.h>, which
> provides the extern declarations for pcibios_plat_dev_init() and
> pcibios_map_irq() via <asm/pci.h>.
>
> This results in these new warnings:
>
> arch/mips/pci/fixup-lantiq.c:13:5: warning: no previous prototype for 'pcibios_plat_dev_init' [-Wmissing-prototypes]
> arch/mips/pci/fixup-lantiq.c:24:5: warning: no previous prototype for 'pcibios_map_irq' [-Wmissing-prototypes]
>
> Include <linux/pci.h> directly to get these declarations.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310070445.tzRBNYRC-lkp@intel.com/
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> arch/mips/pci/fixup-lantiq.c | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>