From: Manivannan Sadhasivam <mani@kernel.org>
To: "Köry Maincent" <kory.maincent@bootlin.com>
Cc: Cai Huoqing <cai.huoqing@linux.dev>,
Serge Semin <fancer.lancer@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>
Subject: Re: [PATCH v2 2/5] dmaengine: dw-edma: Typos fixes
Date: Tue, 10 Oct 2023 20:29:06 +0530 [thread overview]
Message-ID: <20231010145906.GL4884@thinkpad> (raw)
In-Reply-To: <20231002131749.2977952-3-kory.maincent@bootlin.com>
On Mon, Oct 02, 2023 at 03:17:46PM +0200, Köry Maincent wrote:
> From: Kory Maincent <kory.maincent@bootlin.com>
>
> Fix "HDMA_V0_REMOTEL_STOP_INT_EN" typo error.
> Fix "HDMA_V0_LOCAL_STOP_INT_EN" to "HDMA_V0_LOCAL_ABORT_INT_EN" as the STOP
> bit is already set in the same line.
>
You should split this into two patches. First one is a typo and is harmless, but
the second is a _bug_.
- Mani
> Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> ---
> drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 +-
> drivers/dma/dw-edma/dw-hdma-v0-regs.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> index 3e78d4fd3955..0afafc683a9e 100644
> --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> @@ -235,7 +235,7 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first)
> /* Interrupt enable&unmask - done, abort */
> tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) |
> HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK |
> - HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_STOP_INT_EN;
> + HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN;
> SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp);
> /* Channel control */
> SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN);
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-regs.h b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> index a974abdf8aaf..eab5fd7177e5 100644
> --- a/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> @@ -15,7 +15,7 @@
> #define HDMA_V0_LOCAL_ABORT_INT_EN BIT(6)
> #define HDMA_V0_REMOTE_ABORT_INT_EN BIT(5)
> #define HDMA_V0_LOCAL_STOP_INT_EN BIT(4)
> -#define HDMA_V0_REMOTEL_STOP_INT_EN BIT(3)
> +#define HDMA_V0_REMOTE_STOP_INT_EN BIT(3)
> #define HDMA_V0_ABORT_INT_MASK BIT(2)
> #define HDMA_V0_STOP_INT_MASK BIT(0)
> #define HDMA_V0_LINKLIST_EN BIT(0)
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-10-10 14:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 13:17 [PATCH v2 0/5] Fix support of dw-edma HDMA NATIVE IP in remote setup Köry Maincent
2023-10-02 13:17 ` [PATCH v2 1/5] dmaengine: dw-edma: Fix the ch_count hdma callback Köry Maincent
2023-10-03 11:23 ` Serge Semin
2023-10-10 14:56 ` Manivannan Sadhasivam
2023-10-02 13:17 ` [PATCH v2 2/5] dmaengine: dw-edma: Typos fixes Köry Maincent
2023-10-10 14:59 ` Manivannan Sadhasivam [this message]
2023-10-11 7:23 ` Köry Maincent
2023-10-11 10:38 ` Serge Semin
2023-10-02 13:17 ` [PATCH v2 3/5] dmaengine: dw-edma: Add HDMA remote interrupt configuration Köry Maincent
2023-10-10 15:00 ` Manivannan Sadhasivam
2023-10-02 13:17 ` [PATCH v2 4/5] dmaengine: dw-edma: HDMA: Add sync read before starting the DMA transfer in remote setup Köry Maincent
2023-10-03 11:48 ` Serge Semin
2023-10-03 12:15 ` Köry Maincent
2023-10-03 15:20 ` Serge Semin
2023-10-03 15:34 ` Köry Maincent
2023-10-03 15:57 ` Serge Semin
2023-10-02 13:17 ` [PATCH v2 5/5] dmaengine: dw-edma: eDMA: " Köry Maincent
2023-10-03 11:59 ` Serge Semin
2023-10-03 12:17 ` Köry Maincent
2023-10-04 7:21 ` [PATCH v2 0/5] Fix support of dw-edma HDMA NATIVE IP " Vinod Koul
2023-10-04 8:04 ` Köry Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010145906.GL4884@thinkpad \
--to=mani@kernel.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=cai.huoqing@linux.dev \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox