From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10197CD8CA2 for ; Tue, 10 Oct 2023 15:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233263AbjJJPAk (ORCPT ); Tue, 10 Oct 2023 11:00:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233237AbjJJPAi (ORCPT ); Tue, 10 Oct 2023 11:00:38 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46213AC; Tue, 10 Oct 2023 08:00:36 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3E7AC433C7; Tue, 10 Oct 2023 15:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696950035; bh=8XxPnVDAlUJrH1PKK69qfWPgf4kWCU+iIBO+HjlBnjw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CC2kdWe0H2Mb+QzsYE3fmeZ8l8pLrsTgdR3fz+LWTflLfsnfTO/vjg+SnyjG5rPNG /mcfI5IUgRhf0j1kTTTR8oNb0l+dmZULKr0dxeE0AqnAm4g9Iu70dIBtyWPGPArL+N dslSZOz9XmL7yT+/OVk/+RRXf0LdY0aQDKPeO+q1V2a2XLfHU30g/fO2Xpr7xkr5PN 3cpehrRoxSLiB7YFxNnFuhB99uWblCs8kPV0A4U+jWmP1uf9LvSN9soeYGP2wyZpcB B37kP6PX7hzvyywQH4KJuYIfeDRlnEXNWXTEMPKXe1TBXb8BhnDSkfyoyf58eTyAHn vSREfAQgGOVDA== Date: Tue, 10 Oct 2023 20:30:22 +0530 From: Manivannan Sadhasivam To: =?iso-8859-1?Q?K=F6ry?= Maincent Cc: Cai Huoqing , Serge Semin , Vinod Koul , Gustavo Pimentel , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Herve Codina Subject: Re: [PATCH v2 3/5] dmaengine: dw-edma: Add HDMA remote interrupt configuration Message-ID: <20231010150022.GM4884@thinkpad> References: <20231002131749.2977952-1-kory.maincent@bootlin.com> <20231002131749.2977952-4-kory.maincent@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231002131749.2977952-4-kory.maincent@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 02, 2023 at 03:17:47PM +0200, Köry Maincent wrote: > From: Kory Maincent > > Only the local interruption was configured, remote interrupt was left > behind. This patch fix it by setting stop and abort remote interrupts when > the DW_EDMA_CHIP_LOCAL flag is not set. > > Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA") > Signed-off-by: Kory Maincent Acked-by: Manivannan Sadhasivam - Mani > Reviewed-by: Serge Semin > --- > drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c > index 0afafc683a9e..0cce1880cfdc 100644 > --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c > +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c > @@ -236,6 +236,8 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) > tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) | > HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK | > HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; > + if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL)) > + tmp |= HDMA_V0_REMOTE_STOP_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN; > SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp); > /* Channel control */ > SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN); > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்