From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CBA8CD68ED for ; Tue, 10 Oct 2023 06:33:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442281AbjJJGdl (ORCPT ); Tue, 10 Oct 2023 02:33:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442233AbjJJGdj (ORCPT ); Tue, 10 Oct 2023 02:33:39 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD72C9D for ; Mon, 9 Oct 2023 23:33:38 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C131EC433C7; Tue, 10 Oct 2023 06:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696919618; bh=M9p2Y7LB/cIXEwnNrOz2eXKKA/1TPc0wjQK8giZOwMw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=18+KabpN5HcVivpxLnDaNFK21429BKXqzT8XHlySL1WbusIukZOznlgNQSnYuo3hX H5m9r8/cI0WK7WahKHEx05eJB92zeOQO4X9dnOSswzDi/8Q4EGziREg8HdfhixbMYZ an7bGurprT+k2u+fZ0PK4ao0LhFhTu1ii/EfU/ww= Date: Tue, 10 Oct 2023 08:33:35 +0200 From: Greg KH To: Peter Korsgaard Cc: Javier Carrasco , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read Message-ID: <2023101018-venomous-uncured-47cf@gregkh> References: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com> <2023101036-fleshy-dude-aec0@gregkh> <87v8bfc83f.fsf@48ers.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v8bfc83f.fsf@48ers.dk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 10, 2023 at 08:19:48AM +0200, Peter Korsgaard wrote: > >>>>> "Greg" == Greg KH writes: > > > On Tue, Oct 10, 2023 at 12:26:14AM +0200, Javier Carrasco wrote: > >> syzbot has found an uninit-value bug triggered by the dm9601 driver [1]. > >> > >> This error happens because the variable res is not updated if the call > >> to dm_read_shared_word returns an error. In this particular case -EPROTO > >> was returned and res stayed uninitialized. > >> > >> This can be avoided by checking the return value of dm_read_shared_word > >> and propagating the error if the read operation failed. > >> > >> [1] https://syzkaller.appspot.com/bug?extid=1f53a30781af65d2c955 > >> > >> Signed-off-by: Javier Carrasco > >> Reported-and-tested-by: syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com > >> --- > >> Changes in v2: > >> - Remove unnecessary 'err == 0' case > >> - Link to v1: https://lore.kernel.org/r/20231009-topic-dm9601_uninit_mdio_read-v1-1-d4d775e24e3b@gmail.com > >> --- > >> drivers/net/usb/dm9601.c | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > > > What commit id does this fix? > > It has been there since the beginning, so: > > Fixes: d0374f4f9c35cdfbee0 ("USB: Davicom DM9601 usbnet driver") > > Acked-by: Peter Korsgaard Great, can someone add a cc: stable@ tag for this too please? thanks, greg k-h