* arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'var' not described in 'mtrr_overwrite_state'
@ 2023-10-10 16:04 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-10-10 16:04 UTC (permalink / raw)
To: Juergen Gross; +Cc: oe-kbuild-all, linux-kernel, Borislav Petkov (AMD)
Hi Juergen,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 94f6f0550c625fab1f373bb86a6669b45e9748b3
commit: 29055dc74287467bd7a053d60b4afe753832960d x86/mtrr: Support setting MTRR state for software defined MTRRs
date: 4 months ago
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20231010/202310102349.gDBgWNwG-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231010/202310102349.gDBgWNwG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310102349.gDBgWNwG-lkp@intel.com/
All warnings (new ones prefixed by >>):
arch/x86/kernel/cpu/mtrr/generic.c:125: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup_fixed'
arch/x86/kernel/cpu/mtrr/generic.c:125: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup_fixed'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'partial_end' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'repeat' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'uniform' not described in 'mtrr_type_lookup_variable'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'var' not described in 'mtrr_overwrite_state'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'num_var' not described in 'mtrr_overwrite_state'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'def_type' not described in 'mtrr_overwrite_state'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'uniform' not described in 'mtrr_type_lookup'
vim +259 arch/x86/kernel/cpu/mtrr/generic.c
109
110 /**
111 * mtrr_type_lookup_fixed - look up memory type in MTRR fixed entries
112 *
113 * Return the MTRR fixed memory type of 'start'.
114 *
115 * MTRR fixed entries are divided into the following ways:
116 * 0x00000 - 0x7FFFF : This range is divided into eight 64KB sub-ranges
117 * 0x80000 - 0xBFFFF : This range is divided into sixteen 16KB sub-ranges
118 * 0xC0000 - 0xFFFFF : This range is divided into sixty-four 4KB sub-ranges
119 *
120 * Return Values:
121 * MTRR_TYPE_(type) - Matched memory type
122 * MTRR_TYPE_INVALID - Unmatched
123 */
124 static u8 mtrr_type_lookup_fixed(u64 start, u64 end)
> 125 {
126 int idx;
127
128 if (start >= 0x100000)
129 return MTRR_TYPE_INVALID;
130
131 /* 0x0 - 0x7FFFF */
132 if (start < 0x80000) {
133 idx = 0;
134 idx += (start >> 16);
135 return mtrr_state.fixed_ranges[idx];
136 /* 0x80000 - 0xBFFFF */
137 } else if (start < 0xC0000) {
138 idx = 1 * 8;
139 idx += ((start - 0x80000) >> 14);
140 return mtrr_state.fixed_ranges[idx];
141 }
142
143 /* 0xC0000 - 0xFFFFF */
144 idx = 3 * 8;
145 idx += ((start - 0xC0000) >> 12);
146 return mtrr_state.fixed_ranges[idx];
147 }
148
149 /**
150 * mtrr_type_lookup_variable - look up memory type in MTRR variable entries
151 *
152 * Return Value:
153 * MTRR_TYPE_(type) - Matched memory type or default memory type (unmatched)
154 *
155 * Output Arguments:
156 * repeat - Set to 1 when [start:end] spanned across MTRR range and type
157 * returned corresponds only to [start:*partial_end]. Caller has
158 * to lookup again for [*partial_end:end].
159 *
160 * uniform - Set to 1 when an MTRR covers the region uniformly, i.e. the
161 * region is fully covered by a single MTRR entry or the default
162 * type.
163 */
164 static u8 mtrr_type_lookup_variable(u64 start, u64 end, u64 *partial_end,
165 int *repeat, u8 *uniform)
166 {
167 int i;
168 u64 base, mask;
169 u8 prev_match, curr_match;
170
171 *repeat = 0;
172 *uniform = 1;
173
174 prev_match = MTRR_TYPE_INVALID;
175 for (i = 0; i < num_var_ranges; ++i) {
176 unsigned short start_state, end_state, inclusive;
177
178 if (!(mtrr_state.var_ranges[i].mask_lo & MTRR_PHYSMASK_V))
179 continue;
180
181 base = (((u64)mtrr_state.var_ranges[i].base_hi) << 32) +
182 (mtrr_state.var_ranges[i].base_lo & PAGE_MASK);
183 mask = (((u64)mtrr_state.var_ranges[i].mask_hi) << 32) +
184 (mtrr_state.var_ranges[i].mask_lo & PAGE_MASK);
185
186 start_state = ((start & mask) == (base & mask));
187 end_state = ((end & mask) == (base & mask));
188 inclusive = ((start < base) && (end > base));
189
190 if ((start_state != end_state) || inclusive) {
191 /*
192 * We have start:end spanning across an MTRR.
193 * We split the region into either
194 *
195 * - start_state:1
196 * (start:mtrr_end)(mtrr_end:end)
197 * - end_state:1
198 * (start:mtrr_start)(mtrr_start:end)
199 * - inclusive:1
200 * (start:mtrr_start)(mtrr_start:mtrr_end)(mtrr_end:end)
201 *
202 * depending on kind of overlap.
203 *
204 * Return the type of the first region and a pointer
205 * to the start of next region so that caller will be
206 * advised to lookup again after having adjusted start
207 * and end.
208 *
209 * Note: This way we handle overlaps with multiple
210 * entries and the default type properly.
211 */
212 if (start_state)
213 *partial_end = base + get_mtrr_size(mask);
214 else
215 *partial_end = base;
216
217 if (unlikely(*partial_end <= start)) {
218 WARN_ON(1);
219 *partial_end = start + PAGE_SIZE;
220 }
221
222 end = *partial_end - 1; /* end is inclusive */
223 *repeat = 1;
224 *uniform = 0;
225 }
226
227 if ((start & mask) != (base & mask))
228 continue;
229
230 curr_match = mtrr_state.var_ranges[i].base_lo & MTRR_PHYSBASE_TYPE;
231 if (prev_match == MTRR_TYPE_INVALID) {
232 prev_match = curr_match;
233 continue;
234 }
235
236 *uniform = 0;
237 if (check_type_overlap(&prev_match, &curr_match))
238 return curr_match;
239 }
240
241 if (prev_match != MTRR_TYPE_INVALID)
242 return prev_match;
243
244 return mtrr_state.def_type;
245 }
246
247 /**
248 * mtrr_overwrite_state - set static MTRR state
249 *
250 * Used to set MTRR state via different means (e.g. with data obtained from
251 * a hypervisor).
252 * Is allowed only for special cases when running virtualized. Must be called
253 * from the x86_init.hyper.init_platform() hook. It can be called only once.
254 * The MTRR state can't be changed afterwards. To ensure that, X86_FEATURE_MTRR
255 * is cleared.
256 */
257 void mtrr_overwrite_state(struct mtrr_var_range *var, unsigned int num_var,
258 mtrr_type def_type)
> 259 {
260 unsigned int i;
261
262 /* Only allowed to be called once before mtrr_bp_init(). */
263 if (WARN_ON_ONCE(mtrr_state_set))
264 return;
265
266 /* Only allowed when running virtualized. */
267 if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
268 return;
269
270 /*
271 * Only allowed for special virtualization cases:
272 * - when running as Hyper-V, SEV-SNP guest using vTOM
273 * - when running as Xen PV guest
274 * - when running as SEV-SNP or TDX guest to avoid unnecessary
275 * VMM communication/Virtualization exceptions (#VC, #VE)
276 */
277 if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP) &&
278 !hv_is_isolation_supported() &&
279 !cpu_feature_enabled(X86_FEATURE_XENPV) &&
280 !cpu_feature_enabled(X86_FEATURE_TDX_GUEST))
281 return;
282
283 /* Disable MTRR in order to disable MTRR modifications. */
284 setup_clear_cpu_cap(X86_FEATURE_MTRR);
285
286 if (var) {
287 if (num_var > MTRR_MAX_VAR_RANGES) {
288 pr_warn("Trying to overwrite MTRR state with %u variable entries\n",
289 num_var);
290 num_var = MTRR_MAX_VAR_RANGES;
291 }
292 for (i = 0; i < num_var; i++)
293 mtrr_state.var_ranges[i] = var[i];
294 num_var_ranges = num_var;
295 }
296
297 mtrr_state.def_type = def_type;
298 mtrr_state.enabled |= MTRR_STATE_MTRR_ENABLED;
299
300 mtrr_state_set = 1;
301 }
302
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'var' not described in 'mtrr_overwrite_state'
@ 2023-11-12 17:54 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-11-12 17:54 UTC (permalink / raw)
To: Juergen Gross; +Cc: oe-kbuild-all, linux-kernel, Borislav Petkov (AMD)
Hi Juergen,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1b907d0507354b74a4f2c286380cd6059af79248
commit: 29055dc74287467bd7a053d60b4afe753832960d x86/mtrr: Support setting MTRR state for software defined MTRRs
date: 5 months ago
config: i386-allnoconfig (https://download.01.org/0day-ci/archive/20231113/202311130104.9xKAKzke-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231113/202311130104.9xKAKzke-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311130104.9xKAKzke-lkp@intel.com/
All warnings (new ones prefixed by >>):
arch/x86/kernel/cpu/mtrr/generic.c:125: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup_fixed'
arch/x86/kernel/cpu/mtrr/generic.c:125: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup_fixed'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'partial_end' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'repeat' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'uniform' not described in 'mtrr_type_lookup_variable'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'var' not described in 'mtrr_overwrite_state'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'num_var' not described in 'mtrr_overwrite_state'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'def_type' not described in 'mtrr_overwrite_state'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'uniform' not described in 'mtrr_type_lookup'
vim +259 arch/x86/kernel/cpu/mtrr/generic.c
246
247 /**
248 * mtrr_overwrite_state - set static MTRR state
249 *
250 * Used to set MTRR state via different means (e.g. with data obtained from
251 * a hypervisor).
252 * Is allowed only for special cases when running virtualized. Must be called
253 * from the x86_init.hyper.init_platform() hook. It can be called only once.
254 * The MTRR state can't be changed afterwards. To ensure that, X86_FEATURE_MTRR
255 * is cleared.
256 */
257 void mtrr_overwrite_state(struct mtrr_var_range *var, unsigned int num_var,
258 mtrr_type def_type)
> 259 {
260 unsigned int i;
261
262 /* Only allowed to be called once before mtrr_bp_init(). */
263 if (WARN_ON_ONCE(mtrr_state_set))
264 return;
265
266 /* Only allowed when running virtualized. */
267 if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
268 return;
269
270 /*
271 * Only allowed for special virtualization cases:
272 * - when running as Hyper-V, SEV-SNP guest using vTOM
273 * - when running as Xen PV guest
274 * - when running as SEV-SNP or TDX guest to avoid unnecessary
275 * VMM communication/Virtualization exceptions (#VC, #VE)
276 */
277 if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP) &&
278 !hv_is_isolation_supported() &&
279 !cpu_feature_enabled(X86_FEATURE_XENPV) &&
280 !cpu_feature_enabled(X86_FEATURE_TDX_GUEST))
281 return;
282
283 /* Disable MTRR in order to disable MTRR modifications. */
284 setup_clear_cpu_cap(X86_FEATURE_MTRR);
285
286 if (var) {
287 if (num_var > MTRR_MAX_VAR_RANGES) {
288 pr_warn("Trying to overwrite MTRR state with %u variable entries\n",
289 num_var);
290 num_var = MTRR_MAX_VAR_RANGES;
291 }
292 for (i = 0; i < num_var; i++)
293 mtrr_state.var_ranges[i] = var[i];
294 num_var_ranges = num_var;
295 }
296
297 mtrr_state.def_type = def_type;
298 mtrr_state.enabled |= MTRR_STATE_MTRR_ENABLED;
299
300 mtrr_state_set = 1;
301 }
302
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'var' not described in 'mtrr_overwrite_state'
@ 2023-08-30 20:32 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-08-30 20:32 UTC (permalink / raw)
To: Juergen Gross; +Cc: llvm, oe-kbuild-all, linux-kernel, Borislav Petkov (AMD)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1687d8aca5488674686eb46bf49d1d908b2672a1
commit: 29055dc74287467bd7a053d60b4afe753832960d x86/mtrr: Support setting MTRR state for software defined MTRRs
date: 3 months ago
config: i386-allnoconfig (https://download.01.org/0day-ci/archive/20230831/202308310450.02aHerFe-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308310450.02aHerFe-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308310450.02aHerFe-lkp@intel.com/
All warnings (new ones prefixed by >>):
arch/x86/kernel/cpu/mtrr/generic.c:125: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup_fixed'
arch/x86/kernel/cpu/mtrr/generic.c:125: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup_fixed'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'partial_end' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'repeat' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'uniform' not described in 'mtrr_type_lookup_variable'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'var' not described in 'mtrr_overwrite_state'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'num_var' not described in 'mtrr_overwrite_state'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'def_type' not described in 'mtrr_overwrite_state'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'uniform' not described in 'mtrr_type_lookup'
vim +259 arch/x86/kernel/cpu/mtrr/generic.c
246
247 /**
248 * mtrr_overwrite_state - set static MTRR state
249 *
250 * Used to set MTRR state via different means (e.g. with data obtained from
251 * a hypervisor).
252 * Is allowed only for special cases when running virtualized. Must be called
253 * from the x86_init.hyper.init_platform() hook. It can be called only once.
254 * The MTRR state can't be changed afterwards. To ensure that, X86_FEATURE_MTRR
255 * is cleared.
256 */
257 void mtrr_overwrite_state(struct mtrr_var_range *var, unsigned int num_var,
258 mtrr_type def_type)
> 259 {
260 unsigned int i;
261
262 /* Only allowed to be called once before mtrr_bp_init(). */
263 if (WARN_ON_ONCE(mtrr_state_set))
264 return;
265
266 /* Only allowed when running virtualized. */
267 if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
268 return;
269
270 /*
271 * Only allowed for special virtualization cases:
272 * - when running as Hyper-V, SEV-SNP guest using vTOM
273 * - when running as Xen PV guest
274 * - when running as SEV-SNP or TDX guest to avoid unnecessary
275 * VMM communication/Virtualization exceptions (#VC, #VE)
276 */
277 if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP) &&
278 !hv_is_isolation_supported() &&
279 !cpu_feature_enabled(X86_FEATURE_XENPV) &&
280 !cpu_feature_enabled(X86_FEATURE_TDX_GUEST))
281 return;
282
283 /* Disable MTRR in order to disable MTRR modifications. */
284 setup_clear_cpu_cap(X86_FEATURE_MTRR);
285
286 if (var) {
287 if (num_var > MTRR_MAX_VAR_RANGES) {
288 pr_warn("Trying to overwrite MTRR state with %u variable entries\n",
289 num_var);
290 num_var = MTRR_MAX_VAR_RANGES;
291 }
292 for (i = 0; i < num_var; i++)
293 mtrr_state.var_ranges[i] = var[i];
294 num_var_ranges = num_var;
295 }
296
297 mtrr_state.def_type = def_type;
298 mtrr_state.enabled |= MTRR_STATE_MTRR_ENABLED;
299
300 mtrr_state_set = 1;
301 }
302
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'var' not described in 'mtrr_overwrite_state'
@ 2023-08-17 6:38 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-08-17 6:38 UTC (permalink / raw)
To: Juergen Gross; +Cc: oe-kbuild-all, linux-kernel, Borislav Petkov (AMD)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
commit: 29055dc74287467bd7a053d60b4afe753832960d x86/mtrr: Support setting MTRR state for software defined MTRRs
date: 3 months ago
config: i386-randconfig-i011-20230817 (https://download.01.org/0day-ci/archive/20230817/202308171419.RgHfW1sc-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171419.RgHfW1sc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308171419.RgHfW1sc-lkp@intel.com/
All warnings (new ones prefixed by >>):
arch/x86/kernel/cpu/mtrr/generic.c:125: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup_fixed'
arch/x86/kernel/cpu/mtrr/generic.c:125: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup_fixed'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'partial_end' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'repeat' not described in 'mtrr_type_lookup_variable'
arch/x86/kernel/cpu/mtrr/generic.c:166: warning: Function parameter or member 'uniform' not described in 'mtrr_type_lookup_variable'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'var' not described in 'mtrr_overwrite_state'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'num_var' not described in 'mtrr_overwrite_state'
>> arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'def_type' not described in 'mtrr_overwrite_state'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'start' not described in 'mtrr_type_lookup'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'end' not described in 'mtrr_type_lookup'
arch/x86/kernel/cpu/mtrr/generic.c:316: warning: Function parameter or member 'uniform' not described in 'mtrr_type_lookup'
vim +259 arch/x86/kernel/cpu/mtrr/generic.c
246
247 /**
248 * mtrr_overwrite_state - set static MTRR state
249 *
250 * Used to set MTRR state via different means (e.g. with data obtained from
251 * a hypervisor).
252 * Is allowed only for special cases when running virtualized. Must be called
253 * from the x86_init.hyper.init_platform() hook. It can be called only once.
254 * The MTRR state can't be changed afterwards. To ensure that, X86_FEATURE_MTRR
255 * is cleared.
256 */
257 void mtrr_overwrite_state(struct mtrr_var_range *var, unsigned int num_var,
258 mtrr_type def_type)
> 259 {
260 unsigned int i;
261
262 /* Only allowed to be called once before mtrr_bp_init(). */
263 if (WARN_ON_ONCE(mtrr_state_set))
264 return;
265
266 /* Only allowed when running virtualized. */
267 if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
268 return;
269
270 /*
271 * Only allowed for special virtualization cases:
272 * - when running as Hyper-V, SEV-SNP guest using vTOM
273 * - when running as Xen PV guest
274 * - when running as SEV-SNP or TDX guest to avoid unnecessary
275 * VMM communication/Virtualization exceptions (#VC, #VE)
276 */
277 if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP) &&
278 !hv_is_isolation_supported() &&
279 !cpu_feature_enabled(X86_FEATURE_XENPV) &&
280 !cpu_feature_enabled(X86_FEATURE_TDX_GUEST))
281 return;
282
283 /* Disable MTRR in order to disable MTRR modifications. */
284 setup_clear_cpu_cap(X86_FEATURE_MTRR);
285
286 if (var) {
287 if (num_var > MTRR_MAX_VAR_RANGES) {
288 pr_warn("Trying to overwrite MTRR state with %u variable entries\n",
289 num_var);
290 num_var = MTRR_MAX_VAR_RANGES;
291 }
292 for (i = 0; i < num_var; i++)
293 mtrr_state.var_ranges[i] = var[i];
294 num_var_ranges = num_var;
295 }
296
297 mtrr_state.def_type = def_type;
298 mtrr_state.enabled |= MTRR_STATE_MTRR_ENABLED;
299
300 mtrr_state_set = 1;
301 }
302
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-12 17:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-10 16:04 arch/x86/kernel/cpu/mtrr/generic.c:259: warning: Function parameter or member 'var' not described in 'mtrr_overwrite_state' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-11-12 17:54 kernel test robot
2023-08-30 20:32 kernel test robot
2023-08-17 6:38 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox