From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8D29CD68F4 for ; Tue, 10 Oct 2023 06:57:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442354AbjJJG5C (ORCPT ); Tue, 10 Oct 2023 02:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442347AbjJJG46 (ORCPT ); Tue, 10 Oct 2023 02:56:58 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF7AD9F for ; Mon, 9 Oct 2023 23:56:57 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC8C8C433C8; Tue, 10 Oct 2023 06:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696921017; bh=oqvJgyKTmDYPOyjRjWVCgsn+8ih5SG2Zh4gHJ1IAof8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aYtJLJWq3YUa/1rhtyyIZ9Cx48UWR+444TVNvSlMeeMybkCssdqzNZgwRF8izFq/G Unbsgs77e97z8S2/XMxRtjcdpoFJVe1U1AVb3VGrwKX6v3zAL4UlbXZDz7qd19HZ1p 8B7URps2qVuahS41c5TkpB1mlFL+6kf6wzWh9Zn4= Date: Tue, 10 Oct 2023 08:56:54 +0200 From: Greg Kroah-Hartman To: Jerome Brunet Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Neil Armstrong Subject: Re: [PATCH] usb: misc: onboard_usb_hub: extend gl3510 reset duration Message-ID: <2023101036-ambiance-precision-657c@gregkh> References: <20231006101028.1973730-1-jbrunet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006101028.1973730-1-jbrunet@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 06, 2023 at 12:10:28PM +0200, Jerome Brunet wrote: > Initial tests with the gl3510 has been done on libretech aml-a311d-cc. > A 50us reset was fine as long as the hub node was under the usb phy node it > DT. DT schema does not allow that. Moving the hub under the dwc3 controller > caused issues, such as: > > onboard-usb-hub 1-1: Failed to suspend device, error -32 > onboard-usb-hub 1-1: can't set config #1, error -71 > onboard-usb-hub 1-1: Failed to suspend device, error -32 > onboard-usb-hub 1-1: USB disconnect, device number 2 > > Extending the reset duration solves the problem. > Since there is no documentation available for this hub, it is difficult to > know the actual required reset duration. 200us seems to work fine so far. > > Suggested-by: Neil Armstrong > Fixes: 65009ccf7e8f ("usb: misc: onboard_usb_hub: add Genesys Logic gl3510 hub support") I can't find this git id, what tree is it in? thanks, greg k-h