Re: [PATCH v12 5/7] nvmem: core: Rework layouts to become regular devices

Miquel Raynal
2023-10-06T16:33:48Z

Hi Rafał,

rafal@milecki.pl wrote on Fri, 06 Oct 2023 13:49:49 +0200:

> On 2023-10-05 17:59, Miquel Raynal wrote:
> > +static struct bus_type nvmem_layout_bus_type = {
> > + .name = "nvmem-layouts",
> > + .match = nvmem_layout_bus_match,
> > +};
> > +
> > +static struct device nvmem_layout_bus = {
> > + .init_name = "nvmem-layouts",
> > +};
>
> Nitpicking: would it be more consistent and still make sense to use
> singular form "nvmem-layout"?
>
> By looking at my /sys/bus/ I can see there:
> 1. cpu (not cpus)
> 2. gpio (not gpios)
> 3. node (not nodes)
> 4. nvmem (not nvmems)
> etc.
>

Probably, yes. I will wait for more feedback on this series but I'm
fine with the renaming you proposed, makes sense.

Thanks,
Miquèl