Re: [PATCH v12 7/7] nvmem: core: Expose cells through sysfs

Srinivas Kandagatla
2023-10-11T08:27:28Z

On 11/10/2023 08:15, Miquel Raynal wrote:
>>> +
>>> + nvmem_cells_group.bin_attrs = cells_attrs;
>>> +
>>> + ret = devm_device_add_groups(&nvmem->dev, nvmem_cells_groups);
>>> + if (ret)
>>> + goto unlock_mutex;
>> This is going to create groups after the nvmem device is added, isn't this going to be problem with user space notifications?
> Greg said it was not. I hope I understood correctly 😄
>
> And anyway, cells have never been available to userspace, so there is
> nothing userspace might expect yet?
I agree, but once we add sysfs uapi then this is going to change.

--srini

>
> Thanks,
> Miquèl