From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 813EDCD6115 for ; Wed, 11 Oct 2023 08:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345428AbjJKIdQ (ORCPT ); Wed, 11 Oct 2023 04:33:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbjJKIdP (ORCPT ); Wed, 11 Oct 2023 04:33:15 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12C849D; Wed, 11 Oct 2023 01:33:12 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 03B661C000B; Wed, 11 Oct 2023 08:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1697013191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UGFcONc2aMR+cU6na+bydlH0She/NxveqVxUH0lHnGg=; b=XIxL46gTKxHURV3N2CRPsXNdPr2ck39uN1Iu5rAOknw7vXplf+SYFPVQhsTXrU0VykyAib JZRVl3rLFagxdKqsn4M7hev6SpNdWMwPGnSw+SKsyCKRhRGB8eQ+0ik1CudL5aUbDwNu7y MQZZebJArK/b2FjYwvH9ao+ZXaSSUifysoEYV5FvJAnoa4vbo1qPTicGc7drOjq5IHbGKc 6Blgjwf00m43kw7ylhAF+5r7etWWU7iVwSsV2X/GjL5j26fJ2QwSGFeKQf+x4A3EtU1C8N 2uZCGmLZU9x3RD+MXxq6AmSZXdCeSzpJlNzk7dqX/hLhc0niFPigkAnFaYYKXA== Date: Wed, 11 Oct 2023 10:33:06 +0200 From: Miquel Raynal To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , Michael Walle , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Marko , Thomas Petazzoni , Luka Perkov , Randy Dunlap , Chen-Yu Tsai , Daniel Golle Subject: Re: [PATCH v12 7/7] nvmem: core: Expose cells through sysfs Message-ID: <20231011103306.08f1fbd4@xps-13> In-Reply-To: <548849a8-9f11-5274-778e-f291267603bb@linaro.org> References: <20231005155907.2701706-1-miquel.raynal@bootlin.com> <20231005155907.2701706-8-miquel.raynal@bootlin.com> <318fe799-f53e-64ed-b631-d099bb5202f4@linaro.org> <20231011091524.0c9ecc55@xps-13> <548849a8-9f11-5274-778e-f291267603bb@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srinivas, srinivas.kandagatla@linaro.org wrote on Wed, 11 Oct 2023 09:27:20 +0100: > On 11/10/2023 08:15, Miquel Raynal wrote: > >>> + > >>> + nvmem_cells_group.bin_attrs =3D cells_attrs; > >>> + > >>> + ret =3D devm_device_add_groups(&nvmem->dev, nvmem_cells_groups); > >>> + if (ret) > >>> + goto unlock_mutex; =20 > >> This is going to create groups after the nvmem device is added, isn't = this going to be problem with user space notifications? =20 > > Greg said it was not. I hope I understood correctly =F0=9F=98=84 > >=20 > > And anyway, cells have never been available to userspace, so there is > > nothing userspace might expect yet? =20 > I agree, but once we add sysfs uapi then this is going to change. Can you elaborate? I'm not sure I follow you here. Is there still a problem you fear or you think it's okay? Thanks, Miqu=C3=A8l