From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30F3CD6E5A for ; Wed, 11 Oct 2023 10:51:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234806AbjJKKvC (ORCPT ); Wed, 11 Oct 2023 06:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231676AbjJKKu6 (ORCPT ); Wed, 11 Oct 2023 06:50:58 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31339A9; Wed, 11 Oct 2023 03:50:54 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S58cN5jw2z6J9Zf; Wed, 11 Oct 2023 18:47:48 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 11 Oct 2023 11:50:51 +0100 Date: Wed, 11 Oct 2023 11:50:50 +0100 From: Jonathan Cameron To: Bjorn Helgaas CC: , Ilpo =?UTF-8?Q?J=C3=A4rvinen?= , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , , Bjorn Helgaas Subject: Re: [PATCH 01/10] PCI: Use FIELD_GET() Message-ID: <20231011115050.00004e46@Huawei.com> In-Reply-To: <20231010204436.1000644-2-helgaas@kernel.org> References: <20231010204436.1000644-1-helgaas@kernel.org> <20231010204436.1000644-2-helgaas@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Oct 2023 15:44:27 -0500 Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Use FIELD_GET() to remove dependences on the field position, i.e., the > shift value. No functional change intended. > > Signed-off-by: Bjorn Helgaas It's a little unfortunate that some of the masks are called *_MASK and others are not (e.g. PCI_RBAR_CTRL_BAR_SIZE which is a mask). but given they are in include/uapi not sure we can tidy that up unless we add more defines that stick to consistent naming... Otherwise very nice. Reviewed-by: Jonathan Cameron