[PATCH] ASoC: cs42l42: Fix missing include of gpio/consumer.h

[PATCH] ASoC: cs42l42: Fix missing include of gpio/consumer.h

[Richard Fitzgerald]

The call to gpiod_set_value_cansleep() in cs42l42_sdw_update_status()
needs the header file gpio/consumer.h to be included.

This was introduced by commit 2d066c6a7865 ("ASoC: cs42l42: Avoid stale
SoundWire ATTACH after hard reset")

and caused error:
    sound/soc/codecs/cs42l42-sdw.c:374:4: error: implicit declaration of
    function ‘gpiod_set_value_cansleep’;
    did you mean gpio_set_value_cansleep’?

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 2d066c6a7865 ("ASoC: cs42l42: Avoid stale SoundWire ATTACH after hard reset")
---
 sound/soc/codecs/cs42l42-sdw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/cs42l42-sdw.c b/sound/soc/codecs/cs42l42-sdw.c
index 974bae4abfad..94a66a325303 100644
--- a/sound/soc/codecs/cs42l42-sdw.c
+++ b/sound/soc/codecs/cs42l42-sdw.c
@@ -6,6 +6,7 @@
 
 #include <linux/acpi.h>
 #include <linux/device.h>
+#include <linux/gpio/consumer.h>
 #include <linux/iopoll.h>
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
-- 
2.30.2

Re: [PATCH] ASoC: cs42l42: Fix missing include of gpio/consumer.h

[Mark Brown]

On Wed, 11 Oct 2023 14:48:53 +0100, Richard Fitzgerald wrote:
> The call to gpiod_set_value_cansleep() in cs42l42_sdw_update_status()
> needs the header file gpio/consumer.h to be included.
> 
> This was introduced by commit 2d066c6a7865 ("ASoC: cs42l42: Avoid stale
> SoundWire ATTACH after hard reset")
> 
> and caused error:
>     sound/soc/codecs/cs42l42-sdw.c:374:4: error: implicit declaration of
>     function ‘gpiod_set_value_cansleep’;
>     did you mean gpio_set_value_cansleep’?
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs42l42: Fix missing include of gpio/consumer.h
      commit: d6cbc6a3a856a7d8047316d81e2e039e44432acb

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark