Re: [PATCH net-next v2 1/2] net: dsa: Use conduit and user terms

Florian Fainelli
2023-10-23T15:50:23Z

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

Howdy,

On 10/23/2023 12:12 AM, Pavel Machek wrote:
> On Wed 2023-10-11 15:20:25, Florian Fainelli wrote:
>> Use more inclusive terms throughout the DSA subsystem by moving away
>> from "master" which is replaced by "conduit" and "slave" which is
>> replaced by "user". No functional changes.
>
> Note that by making it more "inclusive" you make it incomprehensible
> for users where english is not their first language.

We have use the term conduit and user ports a lot while discussing DSA
just never actually made that part of the code. From that angle, there
are precedent and people more or less familiar with the subsystem should
be able to retrain their muscle memory towards these concepts.

>
> Plus, "user" already means something else in kernel context, so this
> will likely be confusing even for native speakers.

I am open to other suggestions that would make it easier to grasp as a
subsystem, native speaker or else. The "user" ports are user-visible and
controllable, seems quite apt.

>
> This is wrong.

And I am afraid without more substance this is a gratuitous rejection of
change. I am not engaging into why or why we should not be doing that
effort.
--
Florian

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]