From: Greg KH <gregkh@linuxfoundation.org>
To: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Cc: jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
cniedermaier@dh-electronics.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de,
lukas@wunner.de, p.rosenberger@kunbus.com
Subject: Re: [PATCH v2 2/7] serial: amba-pl011: get rid of useless wrapper pl011_get_rs485_mode()
Date: Wed, 11 Oct 2023 19:42:18 +0200 [thread overview]
Message-ID: <2023101134-theater-oversleep-a58b@gregkh> (raw)
In-Reply-To: <20231011173829.10508-3-l.sanfilippo@kunbus.com>
On Wed, Oct 11, 2023 at 07:38:24PM +0200, Lino Sanfilippo wrote:
> Due to earlier code changes function pl011_get_rs485_mode() is now merely
> a wrapper for uart_get_rs485_mode() which does not add any further
> functionality. So remove it and instead call uart_get_rs485_mode()
> directly.
>
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> ---
> drivers/tty/serial/amba-pl011.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
Why is patch 2/7 not cc: stable, when patches 3-7 are? Either this
patch isn't needed in this series, and can go later (or to a different
branch), or it also needs to be marked for stable as the later patches
depend on it?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-11 17:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 17:38 [PATCH v2 0/7] Fixes and improvements for RS485 Lino Sanfilippo
2023-10-11 17:38 ` [PATCH v2 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO Lino Sanfilippo
2023-10-11 17:38 ` [PATCH v2 2/7] serial: amba-pl011: get rid of useless wrapper pl011_get_rs485_mode() Lino Sanfilippo
2023-10-11 17:42 ` Greg KH [this message]
2023-10-11 17:44 ` Lino Sanfilippo
2023-10-11 17:47 ` Greg KH
2023-10-11 17:49 ` Lino Sanfilippo
2023-10-11 17:38 ` [PATCH v2 3/7] serial: core: set missing supported flag for RX during TX GPIO Lino Sanfilippo
2023-10-11 17:38 ` [PATCH v2 4/7] serial: core: fix sanitizing check for RTS settings Lino Sanfilippo
2023-10-11 17:38 ` [PATCH v2 5/7] serial: core: make sure RS485 cannot be enabled when it is not supported Lino Sanfilippo
2023-10-11 17:38 ` [PATCH v2 6/7] serial: core, imx: do not set RS485 enabled if " Lino Sanfilippo
2023-10-11 17:38 ` [PATCH v2 7/7] serial: omap: do not override settings for RS485 support Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101134-theater-oversleep-a58b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=LinoSanfilippo@gmx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=cniedermaier@dh-electronics.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.rosenberger@kunbus.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox