Re: [PATCH V3 03/16] platform/x86/intel/vsec: Use cleanup.h

Joe Perches
2023-10-13T18:15:00Z

On Fri, 2023-10-13 at 13:39 +0300, Ilpo Järvinen wrote:
> Hi,
>
> I added checkpatch people, please check what looks a false positive below.

Yeah, thanks I guess.
The __free uses are very new.
I'll play around with adding it to $Attributes
and see what happens.

> On Thu, 12 Oct 2023, David E. Box wrote:
> > On Thu, 2023-10-12 at 13:25 +0800, kernel test robot wrote:
> > > kernel test robot noticed the following build warnings:
> > > # many are suggestions rather than must-fix
[]
> > > ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
> > > #31: FILE: drivers/platform/x86/intel/vsec.c:159:
> > > +       struct intel_vsec_device __free(kfree) *intel_vsec_dev = NULL;
> >
> > These looks like false positives.
>
> I agree. If I interpret the error message right checkpatch seems to think
> that's a multiplication which is not the case here.