From: Lee Jones <lee@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] mfd: Use device_get_match_data()
Date: Thu, 12 Oct 2023 10:26:18 +0100 [thread overview]
Message-ID: <20231012092618.GF8314@google.com> (raw)
In-Reply-To: <CAGb2v66ZHD8mMMNVwp+sTYT6DAFDUrP8ydeTo7KW+uUtBRM3bQ@mail.gmail.com>
On Tue, 10 Oct 2023, Chen-Yu Tsai wrote:
> On Tue, Oct 10, 2023 at 5:14 AM Rob Herring <robh@kernel.org> wrote:
> >
> > Use preferred device_get_match_data() instead of of_match_device() to
> > get the driver match data. With this, adjust the includes to explicitly
> > include the correct headers.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > drivers/mfd/axp20x.c | 22 +++-------------------
>
> I'd keep the error message, but otherwise for axp20x,
>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>
> > drivers/mfd/hi6421-pmic-core.c | 9 +++------
> > drivers/mfd/mxs-lradc.c | 9 ++-------
> > drivers/mfd/qcom-spmi-pmic.c | 6 ++++--
> > drivers/mfd/qcom_rpm.c | 8 ++++----
> > drivers/mfd/tps65910.c | 11 ++---------
> > drivers/mfd/twl4030-power.c | 9 +++------
> > drivers/mfd/twl6030-irq.c | 10 +++++-----
> > 8 files changed, 26 insertions(+), 58 deletions(-)
FYI, this patch is not in my inbox.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-10-12 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 21:13 [PATCH] mfd: Use device_get_match_data() Rob Herring
2023-10-10 8:27 ` Chen-Yu Tsai
2023-10-10 11:44 ` Rob Herring
2023-10-12 9:26 ` Lee Jones [this message]
2023-10-12 15:04 ` Rob Herring
2023-10-13 10:17 ` Lee Jones
2023-10-13 13:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012092618.GF8314@google.com \
--to=lee@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox