From: Greg KH <gregkh@linuxfoundation.org>
To: "Bartłomiej Konecki" <bartekkonecki97@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: Alignment should match open parenthesis
Date: Thu, 12 Oct 2023 14:20:04 +0200 [thread overview]
Message-ID: <2023101250-shading-skintight-28f7@gregkh> (raw)
In-Reply-To: <ZSfi8nPauVatDm3E@localhost.localdomain>
On Thu, Oct 12, 2023 at 02:13:38PM +0200, Bartłomiej Konecki wrote:
> Fix 2 checks reported by checkpatch.pl in axis-fifo.c
> for alignment should match open parenthesis
>
> Signed-off-by: Bartłomiej Konecki <bartekkonecki97@gmail.com>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Any specific reason you didn't cc: the staging mailing list like
scripts/get_maintainer.pl suggested you do?
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 727b956aa231..ab758a527261 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -381,8 +381,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> */
> mutex_lock(&fifo->read_lock);
> ret = wait_event_interruptible_timeout(fifo->read_queue,
> - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> - read_timeout);
> + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> + read_timeout);
Does this now go over the max line length limit? Does this patch pass
checkpatch.pl?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-12 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 12:13 [PATCH] staging: axis-fifo: Alignment should match open parenthesis Bartłomiej Konecki
2023-10-12 12:20 ` Greg KH [this message]
2023-10-13 6:40 ` Bartłomiej Konecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101250-shading-skintight-28f7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bartekkonecki97@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox