From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1548CDB47E for ; Fri, 13 Oct 2023 08:41:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230098AbjJMIlX (ORCPT ); Fri, 13 Oct 2023 04:41:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230011AbjJMIlT (ORCPT ); Fri, 13 Oct 2023 04:41:19 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31B50B8; Fri, 13 Oct 2023 01:41:17 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S6Kg01Yz1z6H6pg; Fri, 13 Oct 2023 16:39:08 +0800 (CST) Received: from localhost (10.126.172.163) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 13 Oct 2023 09:41:14 +0100 Date: Fri, 13 Oct 2023 09:41:13 +0100 From: Jonathan Cameron To: Shuai Xue CC: Bjorn Helgaas , , , , , , , , , , , , , Subject: Re: [PATCH v7 3/4] drivers/perf: add DesignWare PCIe PMU driver Message-ID: <20231013094113.00003d72@Huawei.com> In-Reply-To: References: <20231012162512.GA1069387@bhelgaas> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.172.163] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > >> + depends on (ARM64 && PCI) > > > > I don't see any actual ARM64 dependency in the code, so maybe omit > > ARM64 (as PCIE_DW_PLAT_HOST does) or add "|| COMPILE_TEST"? > > I will remove the ARM64 dependency and add COMPILE_TEST. don't do both. That makes no sense. either depends on PCI && (ARM64 || COMPILE_TEST) or depends on PCI