From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 54529CDB483
	for <linux-kernel@archiver.kernel.org>; Fri, 13 Oct 2023 15:38:46 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232438AbjJMPip (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 13 Oct 2023 11:38:45 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46796 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232270AbjJMPin (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Oct 2023 11:38:43 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A00C2B7;
        Fri, 13 Oct 2023 08:38:42 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C564C433C8;
        Fri, 13 Oct 2023 15:38:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1697211522;
        bh=lVnd1G0BacgAj5hg/niS/IrsOZDEG8FKK2/F3/5ctjc=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=EzoAOWaRK2AJhRD1gIPgUsyoKp18HiPtgGvYc8ueGj5iyieVvth8Z2imW0lv6Lde2
         nXBvADKYObTTkCnn+tVNA2XzyUzJfX+/WyEohwtUB9sSi9BPJZlWIWALflkblVPQFr
         vYmfPbs54+336BbPs7m0e1fcy6C/Susc+Rl4xVVGSbK1JmJgtsjmPuJ5+sP5KI8dfG
         6WSECSRW4hHHmKxZNUZIGmzERbMB7Jo0JFvzEub6vWnICQ2VK4nD+fvJaUsxlHXfPI
         85X4P5YvnqEYCOvCbTpCjabaGttaM6d7OrE2q427NWUS38c6CrU4HEF6+NUKpuBxZp
         EPRL8GFxi1Fbw==
Date:   Fri, 13 Oct 2023 17:38:38 +0200
From:   Simon Horman <horms@kernel.org>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] appletalk: remove special handling code for ipddp
Message-ID: <20231013153838.GN29570@kernel.org>
References: <20231012063443.22368-1-lukas.bulwahn@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231012063443.22368-1-lukas.bulwahn@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 12, 2023 at 08:34:43AM +0200, Lukas Bulwahn wrote:
> After commit 1dab47139e61 ("appletalk: remove ipddp driver") removes the
> config IPDDP, there is some minor code clean-up possible in the appletalk
> network layer.
> 
> Remove some code in appletalk layer after the ipddp driver is gone.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Thanks,

CONFIG_IPDDP is gone so this code doesn't do anything.

Reviewed-by: Simon Horman <horms@kernel.org>

As a further follow-up should we consider dropping CONFIG_IPDDP*
from various defconfigs it appears in?