From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4575CDB482 for ; Sat, 14 Oct 2023 18:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233250AbjJNS3F (ORCPT ); Sat, 14 Oct 2023 14:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231330AbjJNS3D (ORCPT ); Sat, 14 Oct 2023 14:29:03 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 348C3BF; Sat, 14 Oct 2023 11:29:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8AA2C433C8; Sat, 14 Oct 2023 18:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697308141; bh=P55dAfEs/20Vf0fIuHNJBIzfdHgwpTlHxlsWxHeJ+ls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZYyuF2C99XfL9TrmzG/Q4fy3L6hu/njrAD2ce6hlCcqMLsWHmzENT4ZSbnGLRkYxt A0hlqxTd38QZXhK4929QpyxdeGAM8R3BAiza9PBq5vOoZQZuMys3PDkaznv7c3L4vw /OfWXEjuzRU9Fs2Kad3cKBluDTbSn4C/g4Z42BQk= Date: Sat, 14 Oct 2023 20:28:59 +0200 From: Greg KH To: Cameron Williams Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v2 1/7] tty: 8250: Fix IS-200 PCI ID comment Message-ID: <2023101411-disarray-olive-afc3@gregkh> References: <2023101431-online-sharpness-84d1@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 14, 2023 at 12:56:31PM +0100, Cameron Williams wrote: > On Sat, Oct 14, 2023 at 10:28:33AM +0200, Greg KH wrote: > > On Fri, Oct 13, 2023 at 11:11:09PM +0100, Cameron Williams wrote: > > > Fix the PCI comment for the IS-200 card > > > > "Fix" it how? What was wrong with it, and what is now right with it? > > > I should have specified better, my mistake. The PCI ID comment (135a.0811) > is incorrect, the card ID itself is 0x0d80 and the definition used > (PCI_DEVICE_ID_INTASHIELD_IS200) is indeed 0x0d80. It's just a cosmetic change > as the rest of the IS range of cards are also being added in this series and their > IDs are all 0x0020 offset from each other (though the IS-300, 0x0da0 is in a > parport_serial patch). Makes no functional difference. Please put that info in the changelog text when you send your next version. > > > Signed-off-by: Cameron Williams > > > --- > > > This is a resubmission series for the patch series below. That series > > > was lots of changes sent to lots of maintainers, this series is just for > > > the tty/serial/8250 subsystem. > > > > Your patches here are not threaded at all, was that intentional? Our > > tools will not pick them up properly, and so I would have to do it by > > hand, slowing things down and making me dread handling them. Any reason > > you didn't just use 'git send-email' to send it? > > > This was not intentional, no. I had problems getting git send-email set up, > somthing to do with TLS issues and since Mutt was already set up for general > email, I chose to use that instead for convenience. I can look into getting > git send-email working and re-sending this series as v3 if you want the > series threading properly. You can use mutt to thread things, you need to do it "by hand" with mutt, that's what I used to do all the time before git send-email was created (it's based on some old scripts of mine.) But I would recommend setting up git send-email if you want to send lots of patches over time. thanks, greg k-h